Fix publishing oops.

[kixelated]

Summary by CodeRabbit

• Bug Fixes

  • Fixed Promise handling in encoding operations to enable proper error handling and await behavior.

• Chores

  • Bumped version to 0.9.4.

[coderabbitai]

Walkthrough

The pull request updates the moq package version from 0.9.3 to 0.9.4 and modifies the encode methods in the Group, GroupDrop, and Frame classes. These methods now return the Promise from Message.encode(...) instead of invoking it without returning the result. This change propagates the encode Promise to callers, enabling proper error handling and await behavior.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Title Check	❓ Inconclusive	The pull request title "Fix publishing oops" is vague and uses informal, non-descriptive language that fails to clearly convey what was actually changed. While the title appears related to the changeset (which includes a version bump and Promise return modifications), the word "oops" is a generic placeholder that doesn't describe the specific problem being addressed. A teammate reviewing the commit history would not understand from this title alone that the changes involve either a version bump in package.json or modifications to return Promises from encode methods.	Consider revising the title to be more specific about the actual changes made. A clearer title might reference the specific fix, such as "Return Promise from encode methods to enable proper error handling" or "Bump package version to 0.9.4 and fix encode Promise propagation," which would help readers understand the main objectives of the changeset at a glance.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-publishing

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a08b232 and c60e53b.

📒 Files selected for processing (2)

• js/moq/package.json (1 hunks)
• js/moq/src/lite/group.ts (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Check

🔇 Additional comments (4)

js/moq/package.json (1)

4-4: LGTM!

Appropriate patch version bump for the bug fix.

js/moq/src/lite/group.ts (3)

22-24: Critical fix: Promise is now properly returned.

The addition of return ensures that the Promise from Message.encode() is returned to callers, enabling proper await behavior and error propagation. Without this, the function would have returned immediately, potentially causing race conditions or silent failures.

---

56-58: Critical fix: Promise is now properly returned.

Same fix as Group.encode - the Promise from Message.encode() is now correctly returned.

---

85-87: Critical fix: Promise is now properly returned.

Same fix as the other encode methods - the Promise from Message.encode() is now correctly returned.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}