Allow --tls-disable-verify without false.

[kixelated]

Summary by CodeRabbit

• Refactor
  • Improved command-line flag handling for TLS verification settings to support explicit boolean control with enhanced consistency.

[coderabbitai]

Walkthrough

A modification was made to the tls-disable-verify CLI flag in the client configuration. The change adds clap's ArgAction::SetTrue to the flag, enabling explicit boolean setting through the command-line interface. The field type remains Option. The modification also includes adding a trailing comma following the env attribute line. No changes to public signatures or exported entities were introduced.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "Allow --tls-disable-verify without false." directly and clearly summarizes the main change in the changeset. The modification adds clap ArgAction::SetTrue to the tls-disable-verify flag, fundamentally changing how it can be used on the command line—shifting from a simple presence/absence indicator to an explicit boolean toggle that sets the value to true. The title concisely captures this core purpose and is specific enough that a teammate scanning the history would immediately understand that this change addresses how the flag is invoked at the CLI level. The title is neither vague nor overly broad, and it contains no misleading information.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch allow-action

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 923b071 and e262375.

📒 Files selected for processing (1)

• rs/moq-native/src/client.rs (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

rs/**/src/**/*.rs

📄 CodeRabbit inference engine (CLAUDE.md)

Write Rust tests integrated within source files (unit tests alongside code).

Files:

• rs/moq-native/src/client.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Check

🔇 Additional comments (1)

rs/moq-native/src/client.rs (1)

27-28: LGTM! Clean addition of boolean flag semantics.

The addition of action = clap::ArgAction::SetTrue enables the simpler CLI usage --tls-disable-verify without requiring an explicit value. This works correctly with the Option<bool> field type and the unwrap_or_default() usage at line 113. The trailing comma addition follows Rust style conventions.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}