Skip to content

Remove priority from the catalog#905

Merged
kixelated merged 3 commits intomainfrom
claude/remove-catalog-priority-o4lUf
Feb 4, 2026
Merged

Remove priority from the catalog#905
kixelated merged 3 commits intomainfrom
claude/remove-catalog-priority-o4lUf

Conversation

@kixelated
Copy link
Collaborator

No description provided.

kixelated and others added 2 commits February 4, 2026 19:56
Removes priority field from Audio and Video catalog structs.
Priority values (1 for video, 2 for audio) are hardcoded when
creating Track objects but no longer exposed in the catalog schema.

https://claude.ai/code/session_01231jJm6QuqVpFgRAECf6y7
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

Walkthrough

This change removes the priority field from catalog data structures in both TypeScript and Rust code. Schema definitions, public structs, catalog construction, and example JSON entries no longer include priority. Call sites that previously used per-catalog or per-track priority values were updated to use fixed constants (e.g., Catalog.PRIORITY.*) or hardcoded numeric priorities in consumers. Several import sites switched from type-only to value imports to access the new constants. No other behavioral or API surface changes were introduced.

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess whether the description relates to the changeset. Add a pull request description explaining the motivation, scope, and impact of removing the priority field from the catalog system.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove priority from the catalog' directly and accurately summarizes the main change: removing priority fields across multiple catalog-related files throughout the codebase.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/remove-catalog-priority-o4lUf

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated kixelated enabled auto-merge (squash) February 4, 2026 20:51
@kixelated kixelated merged commit eb3fbf1 into main Feb 4, 2026
1 check passed
@kixelated kixelated deleted the claude/remove-catalog-priority-o4lUf branch February 4, 2026 21:36
@moq-bot moq-bot bot mentioned this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants