Ignore some Rust warnings with the default features.

[kixelated]

No description provided.

[coderabbitai]

Walkthrough

The changes add lint suppression attributes and modify variable naming in QUIC backend handling. In the client module, an #[allow(unreachable_patterns)] attribute is added to the Quinn backend selection match. In the server module, a similar lint suppression attribute is introduced for Quinn backend initialization, and the Quiche accept path is refactored to bind the accept pattern result to a variable named _conn instead of conn, which is then passed to QuicheRequest::accept.

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Merge Conflict Detection	⚠️ Warning	❌ Merge conflicts detected (21 files): ⚔️ CLAUDE.md (content) ⚔️ README.md (content) ⚔️ bun.lock (content) ⚔️ doc/.vitepress/config.ts (content) ⚔️ doc/index.md (content) ⚔️ doc/js/@moq/hang/index.md (content) ⚔️ doc/js/@moq/hang/publish.md (content) ⚔️ doc/js/@moq/hang/watch.md (content) ⚔️ doc/js/@moq/signals.md (content) ⚔️ doc/js/env/web.md (content) ⚔️ doc/js/index.md (content) ⚔️ flake.nix (content) ⚔️ js/hang-demo/package.json (content) ⚔️ js/hang-demo/src/index.ts (content) ⚔️ js/hang-demo/src/publish.ts (content) ⚔️ js/hang/README.md (content) ⚔️ js/hang/package.json (content) ⚔️ js/hang/src/index.ts (content) ⚔️ package.json (content) ⚔️ rs/moq-native/src/client.rs (content) ⚔️ rs/moq-native/src/server.rs (content) These conflicts must be resolved before merging into main.	Resolve conflicts locally and push changes to this branch.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to evaluate relevance to the changeset.	Add a description explaining why these warnings are being suppressed and their impact on the default feature compilation.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: suppressing Rust compiler warnings by adding allow attributes when default features are compiled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ignore-warnings

⚔️ Resolve merge conflicts (beta)

• Auto-commit resolved conflicts to branch ignore-warnings
• Create stacked PR with resolved conflicts
• Post resolved changes as copyable diffs in a comment

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

rs/moq-native/src/server.rs (1)

246-255: Consider applying the same _conn treatment to the iroh_accept arm for consistency.

The _conn rename correctly suppresses the unused-variable warning when the quiche feature is off. However, the iroh_accept arm on line 256 uses conn in an identical conditional-compilation pattern — if default features exclude both quiche and iroh, that arm would produce the same warning.

-			Some(conn) = iroh_accept => {
+			Some(_conn) = iroh_accept => {
 				#[cfg(feature = "iroh")]
 				self.accept.push(async move {
-					let iroh = super::iroh::IrohRequest::accept(conn).await?;
+					let iroh = super::iroh::IrohRequest::accept(_conn).await?;

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}