-
Notifications
You must be signed in to change notification settings - Fork 17
Cmake: Cmake ffmpeg library fix for Windows #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danrossi
wants to merge
22
commits into
moq-dev:main
Choose a base branch
from
danrossi:win-build-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b83a5c7
Cmake: Cmake ffmpeg library fix for Windows
danrossi ea1c0a9
- update markdown code blocks
danrossi 9ffc4e3
- Refactor cmake to search for including provided pre-built libraries…
danrossi 8a2174d
- update latest specfile hashes
danrossi a5a16c1
- Enable swift for macOS to configure OBS correctly.
danrossi af0d546
- move swift language obs setup to buildspec common
danrossi e1ad0af
- revert swift language
danrossi 44877ff
- add libobs-metal patch
danrossi d86e382
- update min xcode requirements to match obs-studio
danrossi e54b024
- Use pkg-config to find system libraries for Linux
danrossi 0d6e7f8
- fix hash for Windows obs source archive
danrossi 9d45afd
- Set minimum Xcode and SDK required to 26.1 to match the obs-studio …
danrossi c34bf51
- fix windows install prefix config
danrossi fa05997
- Fix windows commands doc
danrossi 63cb4ae
- reinstate macos command
danrossi 02bff6d
Merge branch 'moq-dev:main' into win-build-fix
danrossi 136cfb8
- Enable a debug console in Windows if the RUST_LOG env var is set t…
danrossi 9dc4a05
- Add stop signal for connection failures , session and publish errors
danrossi 1ac1ca3
- change pointer reference within libmoq callback
danrossi b0d4fa3
- Revert obs stop signals
danrossi b4d6945
Update min XCode requirements to 26.5 to match upstream changes
danrossi 3cb4031
Merge branch 'moq-dev:main' into win-build-fix
danrossi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| ## Windows Build Instructions | ||
|
|
||
| ### Build Setup | ||
|
|
||
| ```powershell | ||
| Set-ExecutionPolicy Bypass -Scope Process -Force; [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; iex ((New-Object System.Net.WebClient).DownloadString('https://community.chocolatey.org/install.ps1')) | ||
| choco install -y git | ||
| choco install -y cmake --installargs 'ADD_CMAKE_TO_PATH=System' | ||
| choco install visualstudio2026buildtools --package-parameters "--add Microsoft.VisualStudio.Workload.VCTools --includeRecommended" | ||
| choco install rustup | ||
| ``` | ||
|
|
||
| During the rustup installation choose the `nightly` variant. | ||
|
|
||
| Locate "Visual Studio Installer". Click "Modify". Choose "Desktop Development with C++". Check C++ ATL For x64 | ||
|
|
||
| ### Build the OBS fork | ||
|
|
||
| ```powershell | ||
| cd obs-studio | ||
| cmake -G "Visual Studio 18 2026" -A x64 --preset windows-x64 | ||
| cmake --build --preset windows-x64 | ||
| ``` | ||
|
|
||
| ### Build the obs-moq plugin and install | ||
|
|
||
| ```powershell | ||
| cd obs | ||
| cmake -G "Visual Studio 18 2026" -A x64 --preset windows-x64 -DMOQ_LOCAL="../moq" | ||
| cmake --build --preset windows-x64 --target install | ||
| ``` | ||
|
|
||
|
|
||
|
|
||
| ## Debugging Moq Plugin | ||
|
|
||
| ```powershell | ||
| $env:RUST_LOG="debug"; $env:RUST_BACKTRACE=1; $env:OBS_LOG_LEVEL="debug"; Set-Location "build_x64\rundir\RelWithDebInfo\bin\64bit"; & .\obs64.exe --verbose | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
if(EXISTS ...)guard beforefile(READ ...)— fatal error if the path is absent.file(READ ...)on Line 67 will abort CMake configure with an unhelpful fatal error if${dependencies_dir}/${_obs_destination}/libobs-metal/CMakeLists.txtdoes not exist (e.g., partial extraction, unexpected OBS source layout, or obs-studio dependency not yet present). Add an existence check first.🛠️ Proposed fix
The proposed fix also escapes the
.characters in the version range regex (e.g.,3\\.28) so they match literal dots rather than any character, and adds a guard to warn if thestring(REGEX REPLACE)produces no change — which would leave Swift silently un-enabled even though theenable_language(Swift)check triggered.🤖 Prompt for AI Agents