ci: green the nightly — auth the libmoq API lookup, follow the keyring rename#2
Conversation
…g rename Two independent failures in the nightly matrix: - macOS C subscriber: smoke.sh resolves the latest libmoq release via the GitHub API anonymously (60 req/hr per IP). The heavily-NAT'd macOS runners exhaust that, so the lookup returns nothing -> "no libmoq-v* release found" -> the C client drops out and every "* -> c" case fails. Pass GITHUB_TOKEN at the job level so the call is authenticated (1000 req/hr per token). - apt channel: the published keyring was renamed moq-archive-keyring.gpg -> moq-keyring.gpg (and is now served dearmored, which apt's gpgv requires). Track the new URL/path so the apt install matches the documented flow. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR updates the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greens the nightly cross-language smoke run, which had two unrelated failures
(see run 26885380310).
1. macOS C subscriber — anonymous GitHub API rate limit
smoke.shresolves the latestlibmoqrelease via the GitHub API, authenticatedonly if
GITHUB_TOKENis set — but the workflow never exposed it, so the call wasalways anonymous (60 req/hr per IP). The heavily-NAT'd macOS runners share IPs and
exhaust that, so the lookup returns empty:
→ the C subscriber drops out and every
* -> ccaseFAILs. (The Linux jobs ranthe identical code minutes earlier and passed — it's purely the shared-IP limit.)
Fix: set
GITHUB_TOKEN: ${{ github.token }}at the job level.smoke.shalreadyuses it when present; this just wires it in, lifting the limit to 1000 req/hr per
token. Uses the built-in token (not untrusted event input), so no injection risk.
2. apt channel — keyring rename
The published signing keyring was renamed
moq-archive-keyring.gpg->moq-keyring.gpgand is now served dearmored (binary), which apt'sgpgvrequires — see moq-dev/moq#1611 for the root cause (armored keyring made every
apt-get updatefail withNO_PUBKEY). This tracks the new URL/path so the aptinstall step keeps mirroring the documented install flow.
The binary key is already uploaded and verified live at
https://apt.moq.dev/moq-keyring.gpg.🤖 Generated with Claude Code