Skip to content

NO-ISSUE: feat(deploy): add nfd to dependency#62

Merged
hhk7734 merged 4 commits intomainfrom
nfd
Feb 20, 2026
Merged

NO-ISSUE: feat(deploy): add nfd to dependency#62
hhk7734 merged 4 commits intomainfrom
nfd

Conversation

@wonkyooh
Copy link
Copy Markdown
Contributor

add nfd to dependency
update Chart.lock
update README.md
update values.yaml

add nfd to dependency
update Chart.lock
update README.md
update values.yaml
@wonkyooh wonkyooh self-assigned this Feb 20, 2026
Copilot AI review requested due to automatic review settings February 20, 2026 07:12
@wonkyooh wonkyooh requested a review from a team as a code owner February 20, 2026 07:12
@wonkyooh wonkyooh requested review from hhk7734 and nulledge February 20, 2026 07:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds node-feature-discovery (NFD) as an optional Helm dependency to the moai-inference-framework chart, with default values and documentation updates to support deploying NFD (including GPU-node tolerations for the worker).

Changes:

  • Add node-feature-discovery as a Helm chart dependency (aliased as nfd) and update Chart.lock.
  • Introduce nfd configuration in values.yaml, including default worker tolerations for common GPU taints.
  • Update Helm chart README (helm-docs output) to document the new nfd.* values and vendor the NFD chart package.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
deploy/helm/moai-inference-framework/Chart.yaml Adds NFD as a conditional dependency (alias nfd).
deploy/helm/moai-inference-framework/Chart.lock Updates dependency lock to include NFD and refresh digest/generated timestamp.
deploy/helm/moai-inference-framework/values.yaml Adds nfd.enabled and default nfd.worker.tolerations for GPU nodes.
deploy/helm/moai-inference-framework/README.md Documents the new nfd.* values via helm-docs output.
deploy/helm/moai-inference-framework/charts/node-feature-discovery-0.18.3.tgz Vendors the NFD Helm chart artifact.

Comment thread deploy/helm/moai-inference-framework/values.yaml
fix README.md, used helm-docs to generate the file
add 2 tolerations to nfd.worker in values.yaml
Copilot AI review requested due to automatic review settings February 20, 2026 08:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.

@hhk7734 hhk7734 merged commit 9e249a0 into main Feb 20, 2026
3 checks passed
@hhk7734 hhk7734 deleted the nfd branch February 20, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants