Conversation
add nfd to dependency update Chart.lock update README.md update values.yaml
Contributor
There was a problem hiding this comment.
Pull request overview
Adds node-feature-discovery (NFD) as an optional Helm dependency to the moai-inference-framework chart, with default values and documentation updates to support deploying NFD (including GPU-node tolerations for the worker).
Changes:
- Add
node-feature-discoveryas a Helm chart dependency (aliased asnfd) and updateChart.lock. - Introduce
nfdconfiguration invalues.yaml, including default worker tolerations for common GPU taints. - Update Helm chart README (helm-docs output) to document the new
nfd.*values and vendor the NFD chart package.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| deploy/helm/moai-inference-framework/Chart.yaml | Adds NFD as a conditional dependency (alias nfd). |
| deploy/helm/moai-inference-framework/Chart.lock | Updates dependency lock to include NFD and refresh digest/generated timestamp. |
| deploy/helm/moai-inference-framework/values.yaml | Adds nfd.enabled and default nfd.worker.tolerations for GPU nodes. |
| deploy/helm/moai-inference-framework/README.md | Documents the new nfd.* values via helm-docs output. |
| deploy/helm/moai-inference-framework/charts/node-feature-discovery-0.18.3.tgz | Vendors the NFD Helm chart artifact. |
fix README.md, used helm-docs to generate the file
add 2 tolerations to nfd.worker in values.yaml
hhk7734
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add nfd to dependency
update Chart.lock
update README.md
update values.yaml