Conversation
…e MoAI Inference Framework - Introduced MinIO as an S3-compatible object storage backend for Loki. - Added Loki for log aggregation and monitoring. - Included Vector as a log collector. - Updated Chart.yaml and values.yaml to configure new dependencies. - Created necessary ConfigMaps and Secrets for Loki and MinIO integration. - Enhanced README.md with new dependencies and configuration options.
…uisites documentation - Added "peer": true to multiple dependencies in package-lock.json to indicate peer dependencies. - Reformatted import statements in prerequisites.mdx for consistency. - Expanded instructions in prerequisites.mdx to clarify required values for configuration files. - Introduced a new log collection documentation file detailing the setup of Loki and Vector for centralized log management.
…nciples sections - Added guidelines for agent self-improvement to encourage documentation of recurring patterns, mistakes, and design decisions. - Introduced design principles focusing on minimum necessary complexity, documentation over code for edge cases, and rejecting flawed designs before implementation. - Enhanced Helm chart development practices, including sub-chart integration, predictable service names, and separation of concerns in values.yaml. - Provided detailed instructions for MinIO provisioning patterns and YAML anchor usage to improve configuration management.
hhk7734
requested changes
Feb 20, 2026
…rence Framework - Changed Loki and Vector repository URLs to official Grafana and Vector Helm chart repositories. - Updated Chart.lock and Chart.yaml to reflect the new repository locations and ensure consistency. - Revised README.md to include updated repository information for Loki and Vector.
…inio/minio chart
Switch from bitnami/minio (v14.10.5) to the official minio/minio chart (v5.4.0)
from charts.min.io. Update values structure accordingly: auth.rootUser/rootPassword
→ rootUser/rootPassword, and provisioning.{policies,users,buckets} → top-level
policies/users/buckets with accessKey/secretKey field names.
Set default passwords (minio123!, loki123!) so users can deploy without mandatory
password configuration, while still being able to override them.
Also switch loki and vector to their official chart repositories:
- loki: grafana/helm-charts instead of moreh-dev
- vector: helm.vector.dev instead of moreh-dev
Co-authored-by: Cursor <cursoragent@cursor.com>
…in Helm chart - Removed fullnameOverride for MinIO and Loki to allow dynamic naming based on release name. - Updated Loki endpoint in Vector configuration to use release-prefixed service name. - Adjusted BUCKET_HOST in Loki credentials to reflect the new naming convention.
…d prerequisites.mdx for clarity - Revised comments in values.yaml to emphasize the need for strong passwords in production. - Adjusted the example configuration in prerequisites.mdx to reflect the updated structure and optional password overrides for MinIO and Loki users.
…tories - Introduced `AGENTS.md` files in the `test/` and `deploy/helm/` directories to document agent rules and design principles specific to each domain. - Updated the root `AGENTS.md` to reference the new files and clarify where to record task-related insights. - Added guidelines for E2E testing practices and Helm chart development, emphasizing minimum necessary complexity and separation of concerns.
…le charts - Updated the helm-lint target in the Makefile to iterate over each chart directory and lint only those containing a Chart.yaml file, enhancing the linting process for multiple Helm charts.
…dependencies - Added MinIO version (5.4.0) to the dependencies table. - Revised MinIO configuration options, including root user and password settings. - Updated Loki endpoint in Vector configuration to use release-prefixed service name for better deployment flexibility.
… chart - Added `extra_label_selector` to `mif_logs` in values.yaml to only collect logs from pods that opt into MIF log collection. - Updated the log transformation logic in the README.md to handle JSON log formats more effectively, ensuring proper parsing and merging of structured logs.
Contributor
Author
|
아래 내용 확인했어야 했는데, 깜빡하고 확인하지 못해서 지금 작업했습니다.
|
… and configuration details - Updated log collection labels and their descriptions for clarity. - Revised YAML configuration examples for MinIO and Loki to emphasize required fields. - Added instructions for enabling log collection in pods with specific labels. - Clarified JSON log parsing behavior and its implications for log collection.
hhk7734
reviewed
Feb 20, 2026
hhk7734
reviewed
Feb 20, 2026
hhk7734
reviewed
Feb 20, 2026
hhk7734
reviewed
Feb 20, 2026
hhk7734
reviewed
Feb 20, 2026
…r clarity - Revised the example configuration in prerequisites.mdx to remove optional comments for MinIO and Loki settings. - Streamlined the YAML structure to focus on required fields, enhancing clarity for users setting up the MoAI Inference Framework.
… PVC configuration - Updated the prerequisites.mdx documentation to specify that the `<storage-class>` must match an available StorageClass in the cluster. - Added information about the default StorageClass usage and the implications of omitting this parameter, enhancing user understanding of PVC states.
… clarity and content guidelines - Standardized import statements in AGENTS.md for consistency. - Added content guidelines to AGENTS.md to prevent duplication of installation steps in documentation. - Revised log-collection.mdx to streamline installation instructions, directing users to the prerequisites section for required values and installation commands.
…g and enhance clarity - Added guidelines in AGENTS.md to ensure command output blocks specify both language type and title. - Updated log-collection.mdx to reflect the new output formatting, improving consistency and readability for expected command outputs.
… to PromQL - Changed instances of `logql` to `promql` in log-collection.mdx to reflect the correct query language. - Updated docusaurus.config.ts to include `promql` in the additional languages for syntax highlighting.
hhk7734
reviewed
Feb 20, 2026
hhk7734
reviewed
Feb 20, 2026
…onfiguration and documentation for clarity - Disabled persistence for MinIO and Loki in values.yaml to simplify setup. - Clarified instructions in prerequisites.mdx regarding the need to replace AWS credentials. - Updated log-collection.mdx to indicate that no additional configuration is required to get started with MinIO, Loki, and Vector.
…nfigurations and update documentation - Removed specific resource requests and limits for MinIO and Loki in values.yaml to simplify configuration. - Updated log-collection.mdx to reflect changes in resource limits for Vector, enhancing clarity for users.
…ons for Loki and MinIO - Removed specific resource requests and limits for Loki and MinIO in README.md and values.yaml to streamline configuration. - Disabled persistence for Loki and MinIO, enhancing setup simplicity. - Updated documentation to reflect these changes and improve clarity for users.
…d examples - Updated the expected output formatting in log-collection.mdx for both Loki and Vector commands to enhance readability and consistency. - Ensured alignment of output columns for better clarity in command results.
hhk7734
reviewed
Feb 23, 2026
hhk7734
reviewed
Feb 23, 2026
…ow and enhance clarity - Replaced the text-based log collection flow with a mermaid diagram for better visualization. - Improved the representation of components involved in log collection, including Inference Service Pods, Vector, Loki, and Grafana.
…zed log collection with Loki and Vector - Introduced a new document detailing the setup and configuration for centralized log collection using Loki and Vector within the MoAI Inference Framework. - Included an overview diagram, prerequisites, installation steps, verification commands, and guidelines for enabling log collection on pods. - Provided detailed instructions for searching logs in Grafana and outlined architecture details for Loki, Vector, and MinIO.
hhk7734
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
helm chart 작업, docs 작업, AGENTS.md 작업 진행했습니다.