Conversation
Add prefill-decode disaggregation feature doc with DeepSeek-R1 example using dp8-moe-ep8 on MI300X/MI308X, covering Heimdall config and InferenceService setup with workerTemplate for data-parallel presets. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds documentation for Prefill-Decode (PD) disaggregation to the Docusaurus website, with accompanying npm lockfile updates.
Changes:
- Add a new docs page describing PD disaggregation concepts and configuration examples (Heimdall + Odin presets).
- Update
website/package-lock.json, including upgrades to Mermaid-related parsing dependencies and other transitive packages.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
website/docs/features/prefill-decode-disaggregation.mdx |
New feature documentation page for PD disaggregation, including Heimdall plugin config and InferenceService preset examples. |
website/package-lock.json |
Refreshes lockfile, upgrading several transitive dependencies (notably Mermaid parser/Langium). |
Files not reviewed (1)
- website/package-lock.json: Language not supported
Remove redundant H1 heading from PD disaggregation doc since the frontmatter title renders as H1 automatically. Add the no-H1 rule to website AGENTS.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Clarify plugin responsibilities: pd-profile-handler selects pods via scheduling profiles, prefill/decode-filter plugins filter by role label. Add reference doc links, HF_TOKEN env var, and fix variable highlighting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.