Conversation
add nodefeaturerule to helm chart remove nodefeaturerule from config update README.md in mif helm
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves the NodeFeatureRule resource (moai-accelerator) into the Helm chart by making its name configurable via a new values.yaml field, and updates the chart's README accordingly.
Changes:
- Adds
NodeFeatureRuleNameas a configurable top-level value invalues.yaml(defaulting to"moai-accelerator"). - Updates the
NodeFeatureRuletemplate to use the new value via{{ default "moai-accelerator" .Values.NodeFeatureRuleName }}. - Documents the new value in
README.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
values.yaml |
Adds the NodeFeatureRuleName top-level configurable field |
templates/nfd/moai-accelerator.yaml |
Wires the template name to the new values field |
README.md |
Documents the new NodeFeatureRuleName value |
Comments suppressed due to low confidence (1)
deploy/helm/moai-inference-framework/templates/nfd/moai-accelerator.yaml:4
- The
NodeFeatureRuleNamereference here usesPascalCaseand would need to be updated tonodeFeatureRuleNameto match the naming fix invalues.yaml. Additionally, sinceNodeFeatureRuleNameis already explicitly set to"moai-accelerator"invalues.yaml, thedefaultfallback in this template expression is redundant —.Values.NodeFeatureRuleNamewill never be empty under normal Helm rendering. The template can be simplified to just{{ .Values.nfd.nodeFeatureRuleName }}(or whichever corrected key path is used).
hhk7734
requested changes
Mar 2, 2026
update how the nodefeaturerule is named
hhk7734
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add nodefeaturerule to helm chart
remove nodefeaturerule from config
update README.md in mif helm