Skip to content

NO-ISSUE: feat(deploy): add nodefeaturerule#77

Merged
hhk7734 merged 2 commits intomainfrom
nfd
Mar 2, 2026
Merged

NO-ISSUE: feat(deploy): add nodefeaturerule#77
hhk7734 merged 2 commits intomainfrom
nfd

Conversation

@wonkyooh
Copy link
Copy Markdown
Contributor

@wonkyooh wonkyooh commented Mar 2, 2026

add nodefeaturerule to helm chart
remove nodefeaturerule from config
update README.md in mif helm

add nodefeaturerule to helm chart
remove nodefeaturerule from config
update README.md in mif helm
@wonkyooh wonkyooh self-assigned this Mar 2, 2026
Copilot AI review requested due to automatic review settings March 2, 2026 10:33
@wonkyooh wonkyooh requested a review from a team as a code owner March 2, 2026 10:33
@wonkyooh wonkyooh requested review from hhk7734 and nulledge March 2, 2026 10:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves the NodeFeatureRule resource (moai-accelerator) into the Helm chart by making its name configurable via a new values.yaml field, and updates the chart's README accordingly.

Changes:

  • Adds NodeFeatureRuleName as a configurable top-level value in values.yaml (defaulting to "moai-accelerator").
  • Updates the NodeFeatureRule template to use the new value via {{ default "moai-accelerator" .Values.NodeFeatureRuleName }}.
  • Documents the new value in README.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
values.yaml Adds the NodeFeatureRuleName top-level configurable field
templates/nfd/moai-accelerator.yaml Wires the template name to the new values field
README.md Documents the new NodeFeatureRuleName value
Comments suppressed due to low confidence (1)

deploy/helm/moai-inference-framework/templates/nfd/moai-accelerator.yaml:4

  • The NodeFeatureRuleName reference here uses PascalCase and would need to be updated to nodeFeatureRuleName to match the naming fix in values.yaml. Additionally, since NodeFeatureRuleName is already explicitly set to "moai-accelerator" in values.yaml, the default fallback in this template expression is redundant — .Values.NodeFeatureRuleName will never be empty under normal Helm rendering. The template can be simplified to just {{ .Values.nfd.nodeFeatureRuleName }} (or whichever corrected key path is used).

Comment thread deploy/helm/moai-inference-framework/values.yaml Outdated
Comment thread deploy/helm/moai-inference-framework/README.md Outdated
Comment thread deploy/helm/moai-inference-framework/values.yaml Outdated
Comment thread deploy/helm/moai-inference-framework/templates/nfd/moai-accelerator.yaml Outdated
update how the nodefeaturerule is named
@hhk7734 hhk7734 changed the title NO-ISSUE: feat(helm): add nodefeaturerule NO-ISSUE: feat(deploy): add nodefeaturerule Mar 2, 2026
@hhk7734 hhk7734 merged commit 25600b4 into main Mar 2, 2026
4 checks passed
@hhk7734 hhk7734 deleted the nfd branch March 2, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants