Conversation
…plates - Add `spec.framework` and `spec.model.name` to all moreh-vllm, quickstart, and deepseek-r1 InferenceServiceTemplate presets - Update runtime-base and utils (sim) templates with `spec.framework` and Odin template rendering for model name (`deref .Spec "Model" "Name"`) - Remove redundant `ISVC_MODEL_NAME` env var from all presets, runtime-bases, and utils - Replace shell `$ISVC_MODEL_NAME` references in runtime-base and utils scripts with inline Odin template expressions - Update `hack/gen_moreh_vllm_presets.py` to generate new spec fields - Remove deprecated `heimdall.moreh.io/*` labels from runtime-bases and utils - Update `skills/bump-dependency/SKILL.md` with coordinated Odin + preset change documentation including utils coverage
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes how vLLM presets/runtimes communicate “which framework” and “which model” by promoting them to first-class InferenceServiceTemplate.spec fields (spec.framework, spec.model.name), and removes the older ISVC_MODEL_NAME env var / deprecated Heimdall labels in favor of Odin template rendering.
Changes:
- Add
spec.framework: vllmandspec.model.name: <hf_repo>across preset templates (quickstart, deepseek-r1, moreh-vllm) and supporting runtime-base/utils templates. - Update runtime-base and utils templates to use Odin template rendering (
deref .Spec "Model" "Name") instead ofISVC_MODEL_NAME. - Update
hack/gen_moreh_vllm_presets.pyto emit the new spec fields and stop generatingISVC_MODEL_NAME.
Reviewed changes
Copilot reviewed 172 out of 172 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hack/gen_moreh_vllm_presets.py | Generator now emits spec.framework + spec.model.name and drops ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/utils/sim.helm.yaml | Add spec.framework; switch served-model-name/model-path to spec.model.name via Odin template; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/utils/sim-prefill.helm.yaml | Same as above for prefill sim template. |
| deploy/helm/moai-inference-preset/templates/utils/sim-prefill-dp.helm.yaml | Same as above for DP prefill sim template; remove deprecated Heimdall label. |
| deploy/helm/moai-inference-preset/templates/utils/sim-dp.helm.yaml | Same as above for DP sim template; remove deprecated Heimdall label block. |
| deploy/helm/moai-inference-preset/templates/utils/sim-decode.helm.yaml | Same as above for decode sim template; remove deprecated Heimdall label. |
| deploy/helm/moai-inference-preset/templates/utils/sim-decode-dp.helm.yaml | Same as above for DP decode sim template; remove deprecated Heimdall label. |
| deploy/helm/moai-inference-preset/templates/runtime-bases/vllm.helm.yaml | Add spec.framework; replace ISVC_MODEL_NAME usages with spec.model.name (incl. kv-events topic); remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/runtime-bases/vllm-prefill-dp.helm.yaml | Same as above for DP prefill runtime base; remove deprecated Heimdall label. |
| deploy/helm/moai-inference-preset/templates/runtime-bases/vllm-dp.helm.yaml | Same as above for DP runtime base; remove deprecated Heimdall label block. |
| deploy/helm/moai-inference-preset/templates/presets/quickstart/quickstart-vllm-qwen-qwen3-1.7b-prefill-amd-mi300x-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/quickstart/quickstart-vllm-qwen-qwen3-1.7b-prefill-amd-mi250-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/quickstart/quickstart-vllm-qwen-qwen3-1.7b-decode-amd-mi300x-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/quickstart/quickstart-vllm-qwen-qwen3-1.7b-decode-amd-mi250-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/quickstart/quickstart-vllm-qwen-qwen3-1.7b-amd-mi300x-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/quickstart/quickstart-vllm-qwen-qwen3-1.7b-amd-mi250-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/quickstart/quickstart-vllm-meta-llama-llama-3.2-1b-instruct-prefill-amd-mi300x-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/quickstart/quickstart-vllm-meta-llama-llama-3.2-1b-instruct-prefill-amd-mi250-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/quickstart/quickstart-vllm-meta-llama-llama-3.2-1b-instruct-decode-amd-mi300x-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/quickstart/quickstart-vllm-meta-llama-llama-3.2-1b-instruct-decode-amd-mi250-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/quickstart/quickstart-vllm-meta-llama-llama-3.2-1b-instruct-amd-mi300x-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/quickstart/quickstart-vllm-meta-llama-llama-3.2-1b-instruct-amd-mi250-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/quickstart/quickstart-vllm-deepseek-ai-deepseek-r1-prefill-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/quickstart/quickstart-vllm-deepseek-ai-deepseek-r1-decode-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-omni-30b-a3b-thinking-amd-mi250-dp8-moe-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-thinking-2507-fp8-prefill-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-thinking-2507-fp8-prefill-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-thinking-2507-fp8-prefill-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-thinking-2507-fp8-decode-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-thinking-2507-fp8-decode-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-thinking-2507-fp8-decode-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-thinking-2507-fp8-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-thinking-2507-fp8-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-thinking-2507-fp8-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-instruct-2507-fp8-prefill-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-instruct-2507-fp8-prefill-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-instruct-2507-fp8-prefill-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-instruct-2507-fp8-decode-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-instruct-2507-fp8-decode-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-instruct-2507-fp8-decode-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-instruct-2507-fp8-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-instruct-2507-fp8-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-instruct-2507-fp8-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-2507-fp8-prefill-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-2507-fp8-prefill-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-2507-fp8-prefill-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-2507-fp8-decode-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-2507-fp8-decode-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-2507-fp8-decode-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-2507-fp8-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-2507-fp8-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-30b-a3b-2507-fp8-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-235b-a22b-thinking-2507-fp8-prefill-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-235b-a22b-thinking-2507-fp8-prefill-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-235b-a22b-thinking-2507-fp8-decode-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-235b-a22b-thinking-2507-fp8-decode-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-235b-a22b-thinking-2507-fp8-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-235b-a22b-thinking-2507-fp8-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-235b-a22b-instruct-2507-fp8-prefill-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-235b-a22b-instruct-2507-fp8-prefill-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-235b-a22b-instruct-2507-fp8-decode-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-235b-a22b-instruct-2507-fp8-decode-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-235b-a22b-instruct-2507-fp8-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/qwen-qwen3-235b-a22b-instruct-2507-fp8-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/openai-gpt-oss-20b-amd-mi300x-tp8-moe-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/openai-gpt-oss-20b-amd-mi300x-tp4-moe-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/openai-gpt-oss-20b-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/openai-gpt-oss-20b-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/openai-gpt-oss-120b-prefill-amd-mi300x-tp8-moe-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/openai-gpt-oss-120b-prefill-amd-mi300x-tp4-moe-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/openai-gpt-oss-120b-decode-amd-mi300x-tp8-moe-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/openai-gpt-oss-120b-decode-amd-mi300x-tp4-moe-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/openai-gpt-oss-120b-amd-mi300x-tp8-moe-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/openai-gpt-oss-120b-amd-mi300x-tp4-moe-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/openai-gpt-oss-120b-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/openai-gpt-oss-120b-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.3-70b-instruct-prefill-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.3-70b-instruct-prefill-amd-mi300x-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.3-70b-instruct-prefill-amd-mi300x-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.3-70b-instruct-prefill-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.3-70b-instruct-prefill-amd-mi250-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.3-70b-instruct-decode-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.3-70b-instruct-decode-amd-mi300x-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.3-70b-instruct-decode-amd-mi300x-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.3-70b-instruct-decode-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.3-70b-instruct-decode-amd-mi250-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.3-70b-instruct-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.3-70b-instruct-amd-mi300x-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.3-70b-instruct-amd-mi300x-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.3-70b-instruct-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.3-70b-instruct-amd-mi250-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.2-3b-prefill-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.2-3b-instruct-prefill-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.2-3b-instruct-decode-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.2-3b-instruct-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.2-3b-decode-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.2-3b-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.2-1b-prefill-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.2-1b-instruct-prefill-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.2-1b-instruct-decode-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.2-1b-instruct-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.2-1b-decode-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/meta-llama-llama-3.2-1b-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lmsys-gpt-oss-20b-bf16-amd-mi300x-tp8-moe-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lmsys-gpt-oss-20b-bf16-amd-mi300x-tp4-moe-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lmsys-gpt-oss-20b-bf16-amd-mi300x-tp2-moe-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lmsys-gpt-oss-20b-bf16-amd-mi300x-dp8-moe-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lmsys-gpt-oss-20b-bf16-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lmsys-gpt-oss-20b-bf16-amd-mi300x-dp4-moe-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lmsys-gpt-oss-20b-bf16-amd-mi300x-dp4-moe-ep4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lmsys-gpt-oss-120b-bf16-amd-mi300x-tp8-moe-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lmsys-gpt-oss-120b-bf16-amd-mi300x-tp4-moe-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lmsys-gpt-oss-120b-bf16-amd-mi300x-dp8-moe-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lmsys-gpt-oss-120b-bf16-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lmsys-gpt-oss-120b-bf16-amd-mi300x-dp4-moe-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lmsys-gpt-oss-120b-bf16-amd-mi300x-dp4-moe-ep4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lgai-exaone-exaone-3.5-7.8b-instruct-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lgai-exaone-exaone-3.5-7.8b-instruct-amd-mi300x-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lgai-exaone-exaone-3.5-7.8b-instruct-amd-mi300x-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lgai-exaone-exaone-3.5-7.8b-instruct-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lgai-exaone-exaone-3.5-32b-instruct-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lgai-exaone-exaone-3.5-32b-instruct-amd-mi300x-tp4.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lgai-exaone-exaone-3.5-32b-instruct-amd-mi300x-tp2.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/lgai-exaone-exaone-3.5-32b-instruct-amd-mi300x-1.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-v3.2-speciale-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-v3.2-exp-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-v3.2-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-prefill-amd-mi308x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-prefill-amd-mi308x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-prefill-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-prefill-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-mtp-prefill-amd-mi308x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-mtp-prefill-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-mtp-decode-amd-mi308x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-mtp-decode-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-mtp-amd-mi308x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-mtp-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-decode-amd-mi308x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-decode-amd-mi308x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-decode-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-decode-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-amd-mi308x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-amd-mi308x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-0528-prefill-amd-mi308x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-0528-prefill-amd-mi308x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-0528-prefill-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-0528-prefill-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-0528-decode-amd-mi308x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-0528-decode-amd-mi308x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-0528-decode-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-0528-decode-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-0528-amd-mi308x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-0528-amd-mi308x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-0528-amd-mi300x-tp8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/moreh-vllm/0.15.0-260226-rc2/deepseek-ai-deepseek-r1-0528-amd-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/deepseek-r1/vllm-deepseek-r1-prefill-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
| deploy/helm/moai-inference-preset/templates/presets/deepseek-r1/vllm-deepseek-r1-decode-mi300x-dp8-moe-ep8.helm.yaml | Add spec.framework/spec.model.name; remove ISVC_MODEL_NAME. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.frameworkandspec.model.nameto all InferenceServiceTemplate presets (moreh-vllm, quickstart, deepseek-r1)spec.frameworkand Odin template rendering for model nameISVC_MODEL_NAMEenv var from all presets, runtime-bases, and utilsheimdall.moreh.io/*labels from runtime-bases and utilshack/gen_moreh_vllm_presets.pyto generate new spec fieldsskills/bump-dependency/SKILL.mdwith coordinated Odin + preset change documentationTest plan
make helm-lintpassesvllm-hf-hub-offline) inhyeonkinamespaceISVC_MODEL_NAMEandheimdall.moreh.ioreferences — none remain🤖 Generated with Claude Code