Conversation
…ormatting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…, offline hub, and parallelism tips Add info admonitions for: - Istio revision label guidance for multi-control-plane environments - Offline hub templates as an alternative to HF_TOKEN for air-gapped setups - Runtime base template selection based on parallelism strategy (TP/DP/PP) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tion and resource comments Add info admonition explaining PD-specific runtime base template choices (TP/DP/PP) and offline hub template usage. Add inline comments for cluster-specific hardware resources in YAML examples. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The file is local tooling config and should not be tracked in version control. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Docusaurus documentation to improve guidance for quickstart deployments and prefill/decode (PD) disaggregation, plus adds a Prettier ignore rule to avoid reformatting Helm template YAML.
Changes:
- Add
.prettierignorerule to exclude*.helm.yamlfiles from Prettier formatting. - Enhance the quickstart guide with Istio revision label guidance, offline hub template notes, and runtime base selection tips (TP/DP/PP).
- Clarify PD disaggregation docs with runtime base selection guidance and inline YAML comments about cluster-specific resources.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
website/docs/getting-started/quickstart.mdx |
Adds Istio revision label guidance, offline hub template option, and runtime base selection tips. |
website/docs/features/prefill-decode-disaggregation.mdx |
Adds PD runtime base selection guidance and clarifies resource configuration in YAML examples. |
.prettierignore |
Ignores *.helm.yaml so Helm templates aren’t reformatted by Prettier. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Docusaurus website documentation to improve operational guidance in the Quickstart and Prefill/Decode (PD) disaggregation docs, and intends to add Prettier configuration to avoid formatting Helm templates.
Changes:
- Add Istio revision label guidance for Gateway resources in the quickstart.
- Add offline hub template guidance and runtime base (TP/DP/PP) selection tips to quickstart and PD disaggregation docs.
- Update repo ignore rules related to Prettier config (but see review comment).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
website/docs/getting-started/quickstart.mdx |
Adds Istio revision label note, offline hub template guidance, and runtime base selection tips. |
website/docs/features/prefill-decode-disaggregation.mdx |
Adds runtime base selection guidance (TP/DP/PP) and clarifies YAML examples with inline resource comments. |
.gitignore |
Adds .prettierignore to ignored files (currently conflicts with stated PR intent). |
You can also share your feedback on Copilot code review. Take the survey.
hhk7734
deleted the
docs/improve-quickstart-and-pd-disaggregation-guides
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.prettierignoreto exclude Helm templates from formattingTest plan
npm run buildinwebsite/🤖 Generated with Claude Code