NO-ISSUE: fix(deploy): guard NodeFeatureRule with nfd.enabled condition#92
Merged
NO-ISSUE: fix(deploy): guard NodeFeatureRule with nfd.enabled condition#92
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a Helm rendering bug where the NodeFeatureRule resource was still rendered even when nfd.enabled: false, by adding an explicit template-level guard in the parent chart (since the dependency condition only controls the NFD subchart deployment).
Changes:
- Wrap
templates/nfd/moai-accelerator.yamlwith{{- if .Values.nfd.enabled }}/{{- end }}so theNodeFeatureRuleis not rendered when NFD is disabled.
hhk7734
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nfd.enabled: false로 설정해도NodeFeatureRule리소스가 렌더링되는 버그 수정Chart.yaml의condition: nfd.enabled는 NFD 서브차트 배포만 제어하므로, 부모 차트 템플릿에 별도 조건문 추가References
Test plan
helm template test deploy/helm/moai-inference-framework --set nfd.enabled=false | grep -c NodeFeatureRule→ 0helm template test deploy/helm/moai-inference-framework | grep -c NodeFeatureRule→ 1🤖 Generated with Claude Code