_posts: LND: Excessive Failback Exploit #2 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@Arvin21M: ready for review! |
Arvin21M
approved these changes
Dec 4, 2025
Arvin21M
left a comment
Arvin21M
left a comment
There was a problem hiding this comment.
- Just one or two very minor edit requests.
- Otherwise, this reads well, and looks good to go!
|
|
||
| ## The Variant Bug | ||
|
|
||
| While a fix for the original excessive failback bug was included in LND 0.18.0, a minor variant of the bug was missed when the channel was force closed using LND's commitment instead of the attacker's. |
There was a problem hiding this comment.
Suggested change
| While a fix for the original excessive failback bug was included in LND 0.18.0, a minor variant of the bug was missed when the channel was force closed using LND's commitment instead of the attacker's. | |
| While a fix for the original excessive failback bug was included in LND 0.18.0, a minor variant of the bug remained when the channel was force closed using LND's commitment instead of the attacker's. |
| ## Discovery | ||
|
|
||
| This variant was discovered shortly after the original disclosure, while I was [updating](https://github.com/lightning/bolts/pull/1233) BOLT 5 to prevent future excessive failback vulnerabilities. | ||
| I realized there were actually *two* cases that needed to be updated in BOLT 5, while only one of the cases had been patched in LND. |
There was a problem hiding this comment.
Suggested change
| I realized there were actually *two* cases that needed to be updated in BOLT 5, while only one of the cases had been patched in LND. | |
| I realized there were actually *two* cases that needed to be updated in BOLT 5, but only one of the cases had been patched in LND. |
morehouse
force-pushed
the
lnd_excessive_failback_exploit_2
branch
from
bf9e810 to
69db962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.