_posts: LND: Excessive Failback Exploit #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morehouse
force-pushed
the
lnd_excessive_failback_exploit
branch
from
41145ab to
e4f3c1f
Compare
Owner
Author
|
@Arvin21M: Ready for review! |
Arvin21M
approved these changes
Mar 4, 2025
Arvin21M
left a comment
Arvin21M
left a comment
There was a problem hiding this comment.
A few minor/optional edit suggestions.
All the links work and appear to be pointing to the right destination.
This is great! 🙏
| As part of this handling, nodes need to detect when any currently outstanding HTLCs are missing from the confirmed commitment transaction so that those HTLCs can be failed backward on the upstream channel. | ||
|
|
||
| # The Excessive Failback Bug | ||
|
|
There was a problem hiding this comment.
Suggested change
| The function `failBackMissingHtlcs` detects missing HTLCs in a confirmed commitment and initiates their failback. It compares the confirmed commitment’s HTLCs against any other valid counterparty commitment. If an HTLC is missing, LND assumes it was dropped and fails it upstream. | |
There was a problem hiding this comment.
This is more of a "nice to have" as an opening for the section, not critical.
Owner
Author
There was a problem hiding this comment.
I'm having trouble figuring out how to incorporate this in a way that flows smoothly. There's already an explanation of the function after the code block, so I think I'll just leave it as is.
morehouse
force-pushed
the
lnd_excessive_failback_exploit
branch
from
e4f3c1f to
056b121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.