-
-
Notifications
You must be signed in to change notification settings - Fork 13
📚 Update changelog #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📚 Update changelog #128
Conversation
|
I read through the changelog and cannot find any entry describing the addition of handlebars as an engine option - would you also like me to add that to the changelog? |
Codecov Report
@@ Coverage Diff @@
## dev #128 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 39 39
Lines 1921 1921
=======================================
Hits 1894 1894
Misses 27 27Continue to review full report at Codecov.
|
|
@CLiu13 We do not intend to include handlebars in the main repo. Infact we will be moving it to a separate repo. So it can't be a additional feature to main repo. |
|
@CLiu13 , the change log looks OK. please do this:
Otherwise, next I know it is new piece of information. Please feel free to update docs. |
chfw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update it in changelog.yml instead.
|
Thanks for the info on the correct way to update the changelog. Running EDIT: One of those changes resulted in failing travis tests - as a result, I will exclude that change. |
chfw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go
Before raising the PR, here is a check list:
5.1) can someone else understand your changes without your explanation?
6.1) do you have the feeling of achievement?