Skip to content

Conversation

@CLiu13
Copy link
Collaborator

@CLiu13 CLiu13 commented Nov 14, 2018

This adds new global variables for the target and template files.

Closes #29

Before raising the PR, here is a check list:

  1. have you written unit tests for your code changes?
  2. have you run "make format"?
  3. are you requesting to "dev"?
  4. have you updated the change log?
  5. do you think that you can understand your changes after 6 month?
    5.1) can someone else understand your changes without your explanation?
  6. are you pround of your code changes?
    6.1) do you have the feeling of achievement?

Exceptional merge to master. No release will be made
@codecov-io
Copy link

codecov-io commented Nov 14, 2018

Codecov Report

Merging #125 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #125      +/-   ##
==========================================
+ Coverage   98.57%   98.59%   +0.01%     
==========================================
  Files          38       39       +1     
  Lines        1896     1921      +25     
==========================================
+ Hits         1869     1894      +25     
  Misses         27       27
Impacted Files Coverage Δ
moban/engine.py 100% <100%> (ø) ⬆️
tests/fixtures/globals/variables.template 100% <100%> (ø)
tests/test_engine.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190482c...238d705. Read the comment docs.

@CLiu13 CLiu13 changed the title feat: Add new target and template global variables ✨ Add new target and template global variables Nov 14, 2018
Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test which uses these variables in a file which has been included using {% include ... %} . i.e. test nesting of templates doesnt change the global.

Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need a few other mentors to also check this, but it looks good enough for initial approval

This adds new global variables for the target and template files.

Closes #29
Copy link
Member

@chfw chfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat code. no complaints.

@chfw chfw merged commit 9718f5e into moremoban:dev Nov 15, 2018
@chfw
Copy link
Member

chfw commented Nov 15, 2018

oh.. I forgot one thing:

  1. update change log :)

@CLiu13 , would you like to give another PR on the change log update?

@CLiu13
Copy link
Collaborator Author

CLiu13 commented Nov 15, 2018

Sure thing! See #128

@chfw chfw mentioned this pull request Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants