-
-
Notifications
You must be signed in to change notification settings - Fork 13
✨ Add new target and template global variables #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Exceptional merge to master. No release will be made
Codecov Report
@@ Coverage Diff @@
## dev #125 +/- ##
==========================================
+ Coverage 98.57% 98.59% +0.01%
==========================================
Files 38 39 +1
Lines 1896 1921 +25
==========================================
+ Hits 1869 1894 +25
Misses 27 27
Continue to review full report at Codecov.
|
jayvdb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a test which uses these variables in a file which has been included using {% include ... %} . i.e. test nesting of templates doesnt change the global.
jayvdb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need a few other mentors to also check this, but it looks good enough for initial approval
This adds new global variables for the target and template files. Closes #29
chfw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat code. no complaints.
|
oh.. I forgot one thing:
@CLiu13 , would you like to give another PR on the change log update? |
|
Sure thing! See #128 |
This adds new global variables for the target and template files.
Closes #29
Before raising the PR, here is a check list:
5.1) can someone else understand your changes without your explanation?
6.1) do you have the feeling of achievement?