Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Jan 5, 2019

CLiu13 and others added 5 commits January 3, 2019 15:55
This adds the ability to use moban in an ad-hoc manner
without a config file. This also adds environment variables
as a fallback data source if the default/specified data files
do not exist.

Closes #133
@codecov-io
Copy link

codecov-io commented Jan 5, 2019

Codecov Report

Merging #149 into master will decrease coverage by 0.31%.
The diff coverage is 91.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   98.33%   98.02%   -0.32%     
==========================================
  Files          39       40       +1     
  Lines        1857     1970     +113     
==========================================
+ Hits         1826     1931     +105     
- Misses         31       39       +8
Impacted Files Coverage Δ
moban/reporter.py 98.48% <100%> (+0.3%) ⬆️
moban/_version.py 100% <100%> (ø) ⬆️
moban/main.py 100% <100%> (ø) ⬆️
tests/test_utils.py 97.93% <100%> (+0.08%) ⬆️
tests/test_engine.py 100% <100%> (ø) ⬆️
tests/test_main.py 95.55% <100%> (+0.49%) ⬆️
tests/test_context.py 100% <100%> (ø) ⬆️
tests/test_docs.py 100% <100%> (ø) ⬆️
tests/test_reporter.py 100% <100%> (ø) ⬆️
...sts/integration_tests/test_command_line_options.py 98.25% <100%> (-1.75%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eadf553...99bcd21. Read the comment docs.

@chfw chfw closed this Jan 5, 2019
@chfw chfw reopened this Jan 5, 2019
Copy link
Collaborator

@CLiu13 CLiu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chfw chfw mentioned this pull request Jan 6, 2019
@chfw
Copy link
Member Author

chfw commented Jan 6, 2019

Please see the pending suggestion.

@chfw chfw closed this Jan 6, 2019
🐛 json data shall override environment data too
@chfw chfw reopened this Jan 6, 2019
@chfw chfw merged commit f794c20 into master Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants