Skip to content

allow extensions to be append to template engine. #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 18, 2019
Merged

allow extensions to be append to template engine. #175

merged 13 commits into from
Jan 18, 2019

Conversation

@chfw
Copy link
Member

@chfw chfw commented Jan 17, 2019

#90,

meanwhile, provides a fix for #158

chfw and others added 13 commits January 16, 2019 07:46
@chfw
🔥 remove base_engine.py from repo. fix #158. I did not realize that i…
d343b0a 
…t is part of the repo.
@chfw
✨ initial prototype supporting extensions key word
d50e945
@chfw
📚 initial docs
96f22ea
@chfw
✨ put jinja2.ext.do, jinja2.ext.loopcontrols as default because they …
f85a7f2 
…come as part of jinja package. #90
@chfw
💚 enable the support of rnd_requiremnts on windows and mac-os build o…
ce1a96c 
…n azure
@chfw
🔨 refactor test cases
2f5d34f
@chfw
🔨 refactor test cases
970f651
@chfw
🐛 third party extensions as default even when no user extensions are …
96928de 
…nominated: #90
@ayan-b
📚 ☔ Add extension docs and tests
2c3d190 
Related to #90
@chfw
🔨 test extension validator
6237350
@chfw
Merge pull request #174 from ayan-b/docs-ext
8c4c3e7 
📚 ☔  Add extension docs and tests
@chfw
📚 💚 update unit test and level 12 docs
0be534d
@chfw
📚 💄 update documentation
46f1924
@codecov-io
Copy link

codecov-io commented Jan 17, 2019 •
edited
Loading

Codecov Report

Merging #175 into dev will increase coverage by 0.02%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #175      +/-   ##
==========================================
+ Coverage   97.79%   97.82%   +0.02%     
==========================================
  Files          40       40              
  Lines        2044     2071      +27     
==========================================
+ Hits         1999     2026      +27     
  Misses         45       45
Impacted Files Coverage Δ
tests/test_utils.py 94.11% <0%> (ø) ⬆️
tests/test_template.py 89.74% <100%> (-0.26%) ⬇️
tests/test_engine.py 100% <100%> (ø) ⬆️
moban/mobanfile.py 91.04% <100%> (+0.2%) ⬆️
moban/jinja2/engine.py 100% <100%> (ø) ⬆️
moban/plugins.py 98.13% <100%> (+0.04%) ⬆️
moban/constants.py 100% <100%> (ø) ⬆️
moban/_version.py 100% <100%> (ø) ⬆️
tests/test_docs.py 97.64% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b22bdd...46f1924. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #175 into dev will increase coverage by 0.02%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #175      +/-   ##
==========================================
+ Coverage   97.79%   97.82%   +0.02%     
==========================================
  Files          40       40              
  Lines        2044     2071      +27     
==========================================
+ Hits         1999     2026      +27     
  Misses         45       45
Impacted Files Coverage Δ
tests/test_utils.py 94.11% <0%> (ø) ⬆️
tests/test_template.py 89.74% <100%> (-0.26%) ⬇️
tests/test_engine.py 100% <100%> (ø) ⬆️
moban/mobanfile.py 91.04% <100%> (+0.2%) ⬆️
moban/jinja2/engine.py 100% <100%> (ø) ⬆️
moban/plugins.py 98.13% <100%> (+0.04%) ⬆️
moban/constants.py 100% <100%> (ø) ⬆️
moban/_version.py 100% <100%> (ø) ⬆️
tests/test_docs.py 97.64% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b22bdd...46f1924. Read the comment docs.

@chfw chfw requested review from CLiu13, ayan-b and jayvdb January 17, 2019 20:50
@chfw chfw merged commit 9c98da1 into dev Jan 18, 2019
@chfw chfw deleted the extensions branch January 18, 2019 07:08
@chfw chfw mentioned this pull request Jan 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CLiu13 CLiu13 CLiu13 approved these changes

@ayan-b ayan-b Awaiting requested review from ayan-b

@jayvdb jayvdb Awaiting requested review from jayvdb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chfw @codecov-io @CLiu13 @ayan-b