Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Jan 25, 2019

delivers #173

@chfw chfw requested review from CLiu13 and jayvdb January 25, 2019 19:07
@codecov-io
Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #183 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #183   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files          44       44           
  Lines        2121     2121           
=======================================
  Hits         2076     2076           
  Misses         45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9f6cc...135ab8e. Read the comment docs.

@chfw chfw merged commit f05fa43 into dev Jan 26, 2019
@chfw chfw deleted the use-appdirs branch January 26, 2019 10:00
- moban
dependencies:
- ruamel.yaml
- ruamel.yaml==0.15.86
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was there some feature which needed .86 ?

https://build.opensuse.org/package/show/devel:languages:python/python-ruamel.yaml is on .80

I'll try updating it, but that will take longer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wanted to nominate a version instead of any.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the one available on OpenSuse? without considering distros, any working version would be OK.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build.opensuse.org/package/show/devel:languages:python/python-ruamel.yaml is on .80 ; that is good enough for now.

- jinja2>=2.7.1
- lml>=0.0.7
- lml>=0.0.9
- appdirs==1.4.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably allow lower, but this is OK with most updated distros, as 1.4.3 is quite old.

e.g. https://build.opensuse.org/package/show/devel:languages:python/python-appdirs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be too much picky when it comes to OpenSuse?

@chfw chfw restored the use-appdirs branch January 28, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants