Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Jan 28, 2019

fix #183

surprisingly the actual code was missing

@codecov-io
Copy link

codecov-io commented Jan 28, 2019

Codecov Report

Merging #197 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #197      +/-   ##
==========================================
- Coverage   98.39%   98.38%   -0.01%     
==========================================
  Files          44       44              
  Lines        2116     2232     +116     
==========================================
+ Hits         2082     2196     +114     
- Misses         34       36       +2
Impacted Files Coverage Δ
tests/test_utils.py 94.05% <100%> (+0.18%) ⬆️
moban/utils.py 97.63% <100%> (+0.76%) ⬆️
moban/mobanfile.py 97.04% <0%> (-2.15%) ⬇️
...sts/integration_tests/test_command_line_options.py 99.04% <0%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f05fa43...6833f55. Read the comment docs.

@chfw chfw requested review from CLiu13 and jayvdb January 28, 2019 22:07
@chfw
Copy link
Member Author

chfw commented Jan 28, 2019

@CLiu13 , thanks for swift approval.

@chfw chfw merged commit ab77657 into dev Jan 28, 2019
@chfw chfw deleted the use-appdirs branch January 28, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants