release 0.4.4 #270
Merged
release 0.4.4 #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use simple open in copy engine
* 🔨 Ignore error if occurs Closes #265 * 🔬 Add tests for encoding * 🔬 Add tests for encoding * 🔬 regression test binary file copying
…inja2. hence copy engine is hit with such rediculus, useless procedure. now this is confined to jinja2 only
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
========================================
- Coverage 99.19% 98.9% -0.3%
========================================
Files 58 60 +2
Lines 2478 2460 -18
========================================
- Hits 2458 2433 -25
- Misses 20 27 +7
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
- Coverage 99.19% 98.93% -0.27%
==========================================
Files 58 60 +2
Lines 2478 2528 +50
==========================================
+ Hits 2458 2501 +43
- Misses 20 27 +7
Continue to review full report at Codecov.
|
ayan-b
approved these changes
May 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #265 file encoding error when a binary file is being copied.