Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6.0 - PyFileSystem2 support #327

Merged
merged 168 commits into from
Sep 10, 2019
Merged

Release 0.6.0 - PyFileSystem2 support #327

merged 168 commits into from
Sep 10, 2019

Conversation

chfw
Copy link
Member

@chfw chfw commented Sep 9, 2019

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?

More details are in change-log.

Depends on fs 2.4.11: PyFilesystem/pyfilesystem2#330

chfw and others added 20 commits August 10, 2019 23:22
🔨 replace os.path in moban files

🔥 remove one more os line
* 📚 update level 10 moban dependency as git repo. we will use gitfs2 from moremoban

* 🚜 relocate files

* 🔥 remove repo file system openner 🚜 relocate old code to deprecated

* 👕 update coding style

* 💚 fix unit test import

* 🚜 relocate deprecated code to deprecated folder and will start remove later

* 👕 pass moban_command check

* 👕 update coding style

* 📚 add any location to our vision

* 🔥 remove pypi requires from moban. pypifs takes care of it now.

* 🚜 relocated the pip_install code to deprecated folder. ready for future clean up

* 🔬 level 21 can read from tar too

* 🔬 test copy from a tar

* 👕 update coding style

* 🔥 remove useless test fixtures

* 📚 update regresssion test readme
📚 update level 9 and 10 docs about packages required to support

* 📚 update diagram command

* 📚 update architecture diagram
* 🔥 remove appdirs and gitpython from moban dependency list

* 📚 add a use case: template from a s3 bucket

* ✨ add -d for development tracing. fix #185

* 🚜 do not log the exception but as info

* 📚 update documenation

* 🐛 moban -t url -c url -o moban.output failes

* 🔬 more tests

* 👕 fix format

* 📚 update change log and readme

* 🔥 remove unused imports

* 🔬 more tests

* 👕 fix coding style

* 📚 update package url link

* 💚 make travis tests pass

* 💚 make windows tests pass. an osfs was passed to multifs and the invalid characters on windows are different from the ones on linx. hence pypifs and gitfs2 url are seen as invalid on windows. PyFilesystem/pyfilesystem2#347

* 🔥 remove adapter folder

* 🐛 fix build failure on opensuse. resolves #275

* ✨ use released version of pypifs

* 📰 add pypifs as test dependency
* 🔥 use released version gitfs2 for testing

* 🔨 code restructuring

* 🔨 split plugins folder to plugins.py and core

* 🚜 relocate deprecated code to deprecated folder for easy future removal

* 👕 update coding style

* 🚜 rename template to moban_factory for better readability

* 👕 update coding style

* 🚜 relocate deprecated code for future removal
* 🔨 🚜 refactored tests

* 📚 enhanced PR template

* 👕 🚜 beautify the test codes

* 🔨 code refactoring on test docs

* 🔨 fully transform the docs based tests

* 🔬 test assertions for level 21

* 👕 coding style update

* 🔥 deduplication
* 👕 minor update

* 🔨 use multi_fs instance to iterate file instead of an independent file system instance

* ♿ more logging and improve code coherence

* 🚜 update code coherence
* 🐛 update templated count

* 🐛 fix a typeo
* ✨ Allow mobanfile to include data from arbitrary config files. resolves #126

* 🔬 test cases for #126

* 🔬 more test cases

* 👕 update yaml styles

* 📚 update docs
* ✨ -D is added. resolves #256

* 📚 update readme

* 📰 add missing file. related to #256

* ♿ better help texts
* 🔨 move version query to -V and give way for -vvv. #325

* ✨ support notrace, info and debug level verbose. fix #325

* 📚 update readme

* 🔨 give -d the original name space as define, not debug. #325

* ✨ enable minimal requirements testing as fs 2.4.11 has been released

* 📚 note about -V
@codecov-io
Copy link

Codecov Report

Merging #327 into master will decrease coverage by 3.57%.
The diff coverage is 96.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
- Coverage   98.94%   95.36%   -3.58%     
==========================================
  Files          60       51       -9     
  Lines        2553     2547       -6     
==========================================
- Hits         2526     2429      -97     
- Misses         27      118      +91
Impacted Files Coverage Δ
moban/core/strategy.py 96.42% <ø> (ø)
moban/plugins.py 100% <ø> (ø)
moban/deprecated/library.py 100% <ø> (ø)
moban/core/__init__.py 100% <100%> (ø)
moban/utils.py 92.3% <100%> (-5.23%) ⬇️
tests/test_buffered_writer.py 100% <100%> (ø)
moban/data_loaders/json_loader.py 100% <100%> (ø) ⬆️
tests/test_copy_engine.py 100% <100%> (ø) ⬆️
moban/mobanfile/templates.py 100% <100%> (ø) ⬆️
...sts/integration_tests/test_command_line_options.py 100% <100%> (ø) ⬆️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e64e83d...c62ea15. Read the comment docs.

@chfw
Copy link
Member Author

chfw commented Sep 9, 2019

May fix: #170

@chfw chfw merged commit f5d36ec into master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants