Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Oct 12, 2019

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?
  • please add your name and github link to contributors.rst in alphabetical order.

chfw added 4 commits October 7, 2019 07:12
* 📚 add migration notes. #322

* 🚜 relocate files for coherence

* 🚜 relocated plugins.py

* 🚜 grouped all plugins to plugins directory

* 🚜 relocated data loader manager to core folder

* 🚜 relocated definitions to core folder

* 🚜 relocated hashstore to core folder

* 💚 enable plugins to be found as module

* 👕 update coding style

* 💚 update hardcode references

* 🚜 relocate utils
* 💄 pump up the version number

* 🚜 further code refactoring
* 👕 make main's import looks sane

* 🚜 relocate mkdir_p function to external dependencies folder

* 👕 adjust import spacing in files
* ✨ prototype to support intermediate targets. step 1 for #335

* ✨ synchronize with pypi-mobans

* 🔬 📚 test and document intermediate targets]

* 👕 coding style fix

* 👕 fix yaml lint warning

* 💚 fix broken tests

* 💚 make sure store is empty before next parsing session

* 🔨 code refactoring

* 📚 update change log

* 🔬 more tests

* 💚 update unit test

* 📚 update doc

* 📚 update documentation links

* 📚 update release date
@chfw chfw requested review from CLiu13, ayan-b and jayvdb October 12, 2019 19:43
@codecov-io
Copy link

codecov-io commented Oct 12, 2019

Codecov Report

Merging #344 into master will increase coverage by 0.06%.
The diff coverage is 99.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   95.94%   96.01%   +0.06%     
==========================================
  Files          51       51              
  Lines        2616     2658      +42     
==========================================
+ Hits         2510     2552      +42     
  Misses        106      106
Impacted Files Coverage Δ
moban/externals/reporter.py 96.15% <ø> (ø)
moban/plugins/jinja2/tests/win32.py 66.66% <ø> (ø)
tests/mobanfile/test_targets.py 97.1% <100%> (ø) ⬆️
tests/utils.py 100% <100%> (ø) ⬆️
moban/_version.py 100% <100%> (ø) ⬆️
tests/mobanfile/test_mobanfile.py 100% <100%> (ø) ⬆️
tests/test_reporter.py 100% <100%> (ø) ⬆️
moban/plugins/jinja2/tests/files.py 85.71% <100%> (ø)
moban/core/mobanfile/store.py 100% <100%> (ø)
moban/plugins/jinja2/filters/text.py 18.18% <100%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9633e...8ee45b0. Read the comment docs.

@chfw chfw merged commit 2683e96 into master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants