Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Dec 7, 2019

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?
  • please add your name and github link to contributors.rst in alphabetical order.

chfw added 7 commits December 4, 2019 18:19
* 📚 update demo gif

* 📚 add the git demo to readme
* 🐛 fix reporting for rendering a single file or a string template

* 📚 pump version and update change log

* 💄 shrink the width of demo gif

* 💚 update yaml style
@codecov-io
Copy link

codecov-io commented Dec 7, 2019

Codecov Report

Merging #358 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #358      +/-   ##
=========================================
+ Coverage    96.3%   96.3%   +<.01%     
=========================================
  Files          55      55              
  Lines        2812    2814       +2     
=========================================
+ Hits         2708    2710       +2     
  Misses        104     104
Impacted Files Coverage Δ
moban/_version.py 100% <100%> (ø) ⬆️
moban/core/moban_factory.py 98.1% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65bfc7e...3877e58. Read the comment docs.

@chfw
Copy link
Member Author

chfw commented Dec 7, 2019

@jayvdb , please note

python 3.4 support is gone because colorama requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*'

it is not down to 'moban' to decide

@chfw chfw merged commit a823a37 into master Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants