Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Jun 13, 2018

delivers #28

@chfw
Copy link
Member Author

chfw commented Jun 13, 2018

Please note: even though source and dest are the same file, however, moban has never been run, the copying will happen at least once.

@chfw chfw requested a review from jayvdb June 13, 2018 17:40
@codecov-io
Copy link

codecov-io commented Jun 13, 2018

Codecov Report

Merging #69 into dev will decrease coverage by 0.26%.
The diff coverage is 94.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #69      +/-   ##
==========================================
- Coverage   98.82%   98.56%   -0.27%     
==========================================
  Files          32       32              
  Lines        1280     1325      +45     
==========================================
+ Hits         1265     1306      +41     
- Misses         15       19       +4
Impacted Files Coverage Δ
moban/engine.py 98.62% <100%> (+0.66%) ⬆️
moban/main.py 100% <100%> (ø) ⬆️
tests/test_copier.py 100% <100%> (ø) ⬆️
tests/test_hash_store.py 100% <100%> (ø) ⬆️
moban/reporter.py 95.34% <50%> (-2.22%) ⬇️
moban/copier.py 96.66% <85.71%> (+0.23%) ⬆️
moban/hashstore.py 96.96% <88.88%> (-3.04%) ⬇️
tests/test_template.py 89.74% <0%> (-5.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf2854...18bbf43. Read the comment docs.

@chfw chfw merged commit ee725fc into dev Jun 15, 2018
@chfw chfw deleted the lazy-copy branch June 15, 2018 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants