fixed #273 - resolvecontainer fix#275
Merged
bingenito merged 5 commits intomorganstanley:masterfrom Sep 10, 2019
Merged
Conversation
Contributor
anubhavbisaria
commented
Aug 16, 2019
anubhavbisaria
commented
- resolve Container resolves the last container instead of first
- fixed the test to mockContainer
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
+ Coverage 93.71% 93.73% +0.01%
==========================================
Files 16 16
Lines 1512 1516 +4
Branches 261 262 +1
==========================================
+ Hits 1417 1421 +4
Misses 95 95
|
psmulovics
reviewed
Aug 16, 2019
bingenito
reviewed
Aug 26, 2019
bingenito
reviewed
Aug 26, 2019
…cilitate resolving containers in order of registration fixed morganstanley#273 - fixed splice parameters to remove all registrations
…vbisaria/desktopJS into 273-resolve-container-fix
bingenito
approved these changes
Sep 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.