Add check for valid container registration before invoking create#296
Merged
bingenito merged 1 commit intomorganstanley:masterfrom Feb 6, 2020
Merged
Add check for valid container registration before invoking create#296bingenito merged 1 commit intomorganstanley:masterfrom
bingenito merged 1 commit intomorganstanley:masterfrom
Conversation
Member
Author
|
@anubhavbisaria How does this look to you? |
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 93.37% 93.37%
=======================================
Files 16 16
Lines 1539 1539
Branches 264 265 +1
=======================================
Hits 1437 1437
Misses 102 102
|
psmulovics
approved these changes
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enumeration of registrations with none found results in an attempt to invoke create on a non defined registration. We need to check if it is defined first.
Fixes #295