Added get/setParent to ContainerWindow#308
Merged
bingenito merged 2 commits intomorganstanley:masterfrom May 7, 2020
Merged
Conversation
psmulovics
reviewed
May 6, 2020
| } | ||
|
|
||
| public getParent(): Promise<ContainerWindow> { | ||
| // on the web, there's no parent |
Contributor
Author
There was a problem hiding this comment.
I found this PR (it's symphony, not openfin - or is it?) where they treat opener as parent.
However, in our case I don't think we should. The parent window:
- is always behind the child windows
- closes its children when closed
- activates/resotres its children when restored
The opener doesn't do any of those.
Member
There was a problem hiding this comment.
Should we blank out the getParent you have in OpenFin here as I think that is the opener?
Contributor
Author
There was a problem hiding this comment.
We don't really use getParent, and if they implement setParent correctly, they must "fix" getParent as well. However, to make setParent/getParent calls consistent, I think we should blank it out.
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
+ Coverage 93.37% 93.43% +0.06%
==========================================
Files 16 16
Lines 1539 1554 +15
Branches 265 265
==========================================
+ Hits 1437 1452 +15
Misses 102 102
|
psmulovics
previously approved these changes
May 6, 2020
psmulovics
approved these changes
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.