Skip to content

Pick up librdkafka v1.5.0 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Pick up librdkafka v1.5.0 #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 48 additions & 47 deletions .github/workflows/on_pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ name: pull_request
on: [push, pull_request]

env:
CPU_CORE_NUM: 2
CPU_CORE_NUM : 2
LIBRDKAFKA_VERSION: 1.5.0

jobs:
build_gcc_debug:
Expand Down Expand Up @@ -33,16 +34,16 @@ jobs:
mkdir -p googletest
cd googletest
env CC=gcc CXX=g++ cmake /usr/src/googletest/
make -j$CPU_CORE_NUM && sudo make install
make -j${CPU_CORE_NUM} && sudo make install
cd ../
# 4. Install boost lib
sudo apt install -y libboost-all-dev
# 5. Install librdkafka
wget https://github.com/edenhill/librdkafka/archive/v1.4.2.tar.gz
tar -xvzf v1.4.2.tar.gz
cd librdkafka-1.4.2
wget https://github.com/edenhill/librdkafka/archive/v${LIBRDKAFKA_VERSION}.tar.gz
tar -xvzf v${LIBRDKAFKA_VERSION}.tar.gz
cd librdkafka-${LIBRDKAFKA_VERSION}
./configure
make -j$CPU_CORE_NUM && sudo make install
make -j${CPU_CORE_NUM} && sudo make install
cd ../
# 6. Install zookeeper
wget https://mirrors.bfsu.edu.cn/apache/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2-bin.tar.gz
Expand All @@ -59,7 +60,7 @@ jobs:
- name: Build
run: |
cd $BUILD_SUB_DIR
make -j$CPU_CORE_NUM VERBOSE=1
make -j${CPU_CORE_NUM} VERBOSE=1
- name: Test
run: |
cd $BUILD_SUB_DIR
Expand Down Expand Up @@ -102,16 +103,16 @@ jobs:
mkdir -p googletest
cd googletest
env CC=gcc CXX=g++ cmake /usr/src/googletest/
make -j$CPU_CORE_NUM && sudo make install
make -j${CPU_CORE_NUM} && sudo make install
cd ../
# 4. Install boost lib
sudo apt install -y libboost-all-dev
# 5. Install librdkafka
wget https://github.com/edenhill/librdkafka/archive/v1.4.2.tar.gz
tar -xvzf v1.4.2.tar.gz
cd librdkafka-1.4.2
wget https://github.com/edenhill/librdkafka/archive/v${LIBRDKAFKA_VERSION}.tar.gz
tar -xvzf v${LIBRDKAFKA_VERSION}.tar.gz
cd librdkafka-${LIBRDKAFKA_VERSION}
./configure
make -j$CPU_CORE_NUM && sudo make install
make -j${CPU_CORE_NUM} && sudo make install
cd ../
# 6. Install zookeeper
wget https://mirrors.bfsu.edu.cn/apache/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2-bin.tar.gz
Expand All @@ -128,7 +129,7 @@ jobs:
- name: Build
run: |
cd $BUILD_SUB_DIR
make -j$CPU_CORE_NUM VERBOSE=1
make -j${CPU_CORE_NUM} VERBOSE=1
- name: Test
run: |
cd $BUILD_SUB_DIR
Expand Down Expand Up @@ -176,9 +177,9 @@ jobs:
# 4. Install boost lib
sudo apt install -y libboost-all-dev
# 5. Install librdkafka
wget https://github.com/edenhill/librdkafka/archive/v1.4.2.tar.gz
tar -xvzf v1.4.2.tar.gz
cd librdkafka-1.4.2
wget https://github.com/edenhill/librdkafka/archive/v${LIBRDKAFKA_VERSION}.tar.gz
tar -xvzf v${LIBRDKAFKA_VERSION}.tar.gz
cd librdkafka-${LIBRDKAFKA_VERSION}
./configure
make && sudo make install
cd ../
Expand All @@ -197,7 +198,7 @@ jobs:
- name: Build
run: |
cd $BUILD_SUB_DIR
make -j$CPU_CORE_NUM VERBOSE=1
make -j${CPU_CORE_NUM} VERBOSE=1
- name: Test
run: |
cd $BUILD_SUB_DIR
Expand Down Expand Up @@ -240,16 +241,16 @@ jobs:
mkdir -p googletest
cd googletest
env CC=gcc CXX=g++ cmake /usr/src/googletest/
make -j$CPU_CORE_NUM && sudo make install
make -j${CPU_CORE_NUM} && sudo make install
cd ../
# 4. Install boost lib
sudo apt install -y libboost-all-dev
# 5. Install librdkafka
wget https://github.com/edenhill/librdkafka/archive/v1.4.2.tar.gz
tar -xvzf v1.4.2.tar.gz
cd librdkafka-1.4.2
wget https://github.com/edenhill/librdkafka/archive/v${LIBRDKAFKA_VERSION}.tar.gz
tar -xvzf v${LIBRDKAFKA_VERSION}.tar.gz
cd librdkafka-${LIBRDKAFKA_VERSION}
./configure
make -j$CPU_CORE_NUM && sudo make install
make -j${CPU_CORE_NUM} && sudo make install
cd ../
# 6. Install zookeeper
wget https://mirrors.bfsu.edu.cn/apache/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2-bin.tar.gz
Expand All @@ -266,7 +267,7 @@ jobs:
- name: Build
run: |
cd $BUILD_SUB_DIR
make -j$CPU_CORE_NUM VERBOSE=1
make -j${CPU_CORE_NUM} VERBOSE=1
- name: Test
run: |
cd $BUILD_SUB_DIR
Expand Down Expand Up @@ -308,16 +309,16 @@ jobs:
mkdir -p googletest
cd googletest
env CC=gcc CXX=g++ cmake /usr/src/googletest/
make -j$CPU_CORE_NUM && sudo make install
make -j${CPU_CORE_NUM} && sudo make install
cd ../
# 4. Install boost lib
sudo apt install -y libboost-all-dev
# 5. Install librdkafka
wget https://github.com/edenhill/librdkafka/archive/v1.4.2.tar.gz
tar -xvzf v1.4.2.tar.gz
cd librdkafka-1.4.2
wget https://github.com/edenhill/librdkafka/archive/v${LIBRDKAFKA_VERSION}.tar.gz
tar -xvzf v${LIBRDKAFKA_VERSION}.tar.gz
cd librdkafka-${LIBRDKAFKA_VERSION}
./configure
make -j$CPU_CORE_NUM && sudo make install
make -j${CPU_CORE_NUM} && sudo make install
cd ../
# 6. Install zookeeper
wget https://mirrors.bfsu.edu.cn/apache/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2-bin.tar.gz
Expand All @@ -334,7 +335,7 @@ jobs:
- name: Build
run: |
cd $BUILD_SUB_DIR
make -j$CPU_CORE_NUM VERBOSE=1
make -j${CPU_CORE_NUM} VERBOSE=1
- name: Test
run: |
cd $BUILD_SUB_DIR
Expand Down Expand Up @@ -376,16 +377,16 @@ jobs:
mkdir -p googletest
cd googletest
env CC=gcc CXX=g++ cmake /usr/src/googletest/
make -j$CPU_CORE_NUM && sudo make install
make -j${CPU_CORE_NUM} && sudo make install
cd ../
# 4. Install boost lib
sudo apt install -y libboost-all-dev
# 5. Install librdkafka
wget https://github.com/edenhill/librdkafka/archive/v1.4.2.tar.gz
tar -xvzf v1.4.2.tar.gz
cd librdkafka-1.4.2
wget https://github.com/edenhill/librdkafka/archive/v${LIBRDKAFKA_VERSION}.tar.gz
tar -xvzf v${LIBRDKAFKA_VERSION}.tar.gz
cd librdkafka-${LIBRDKAFKA_VERSION}
./configure
make -j$CPU_CORE_NUM && sudo make install
make -j${CPU_CORE_NUM} && sudo make install
cd ../
# 6. Install zookeeper
wget https://mirrors.bfsu.edu.cn/apache/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2-bin.tar.gz
Expand All @@ -402,7 +403,7 @@ jobs:
- name: Build
run: |
cd $BUILD_SUB_DIR
make -j$CPU_CORE_NUM VERBOSE=1
make -j${CPU_CORE_NUM} VERBOSE=1
- name: Test
run: |
cd $BUILD_SUB_DIR
Expand Down Expand Up @@ -445,16 +446,16 @@ jobs:
mkdir -p googletest
cd googletest
cmake /usr/src/googletest/
make -j$CPU_CORE_NUM && sudo make install
make -j${CPU_CORE_NUM} && sudo make install
cd ../
# 4. Install boost lib
sudo apt install -y libboost-all-dev
# 5. Install librdkafka
wget https://github.com/edenhill/librdkafka/archive/v1.4.2.tar.gz
tar -xvzf v1.4.2.tar.gz
cd librdkafka-1.4.2
wget https://github.com/edenhill/librdkafka/archive/v${LIBRDKAFKA_VERSION}.tar.gz
tar -xvzf v${LIBRDKAFKA_VERSION}.tar.gz
cd librdkafka-${LIBRDKAFKA_VERSION}
./configure
make -j$CPU_CORE_NUM && sudo make install
make -j${CPU_CORE_NUM} && sudo make install
cd ../
# 6. Install zookeeper
wget https://mirrors.bfsu.edu.cn/apache/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2-bin.tar.gz
Expand All @@ -471,7 +472,7 @@ jobs:
- name: Build
run: |
cd $BUILD_SUB_DIR
make -j$CPU_CORE_NUM VERBOSE=1
make -j${CPU_CORE_NUM} VERBOSE=1
- name: Test
run: |
cd $BUILD_SUB_DIR
Expand Down Expand Up @@ -516,16 +517,16 @@ jobs:
mkdir -p googletest
cd googletest
env CC=clang CXX=clang++ cmake /usr/src/googletest/
make -j$CPU_CORE_NUM && sudo make install
make -j${CPU_CORE_NUM} && sudo make install
cd ../
# 4. Install boost lib
sudo apt install -y libboost-all-dev
# 5. Install librdkafka
wget https://github.com/edenhill/librdkafka/archive/v1.4.2.tar.gz
tar -xvzf v1.4.2.tar.gz
cd librdkafka-1.4.2
wget https://github.com/edenhill/librdkafka/archive/v${LIBRDKAFKA_VERSION}.tar.gz
tar -xvzf v${LIBRDKAFKA_VERSION}.tar.gz
cd librdkafka-${LIBRDKAFKA_VERSION}
./configure
make -j$CPU_CORE_NUM && sudo make install
make -j${CPU_CORE_NUM} && sudo make install
cd ../
- name: Config
run: |
Expand All @@ -534,7 +535,7 @@ jobs:
- name: Build
run: |
cd $BUILD_SUB_DIR
make -j$CPU_CORE_NUM VERBOSE=1
make -j${CPU_CORE_NUM} VERBOSE=1

build_doc:
name: Generate Documents
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The `Modern C++ based Kafka API` is a layer of C++ wrapper based on [librdkafka]

Here is the [doxygen documentation for developers](doxygen/annotated.html).

- At present, the `Modern C++ based Kafka API` is compatible with `librdkafka` v1.4.2.
- At present, the `Modern C++ based Kafka API` is compatible with `librdkafka` v1.5.0.

## Why it's here

Expand Down
6 changes: 3 additions & 3 deletions include/kafka/KafkaConsumer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,9 @@ class KafkaConsumer: public KafkaClient
/**
* Get the offsets for the given partitions by time-point.
* Throws KafkaException with errors:
* - RD_KAFKA_RESP_ERR__TIMED_OUT: Not all offsets could be fetched in time.
* - RD_KAFKA_RESP_ERR__UNKNOWN_PARTITION: All partitions are unknown.
* - RD_KAFKA_RESP_ERR__LEADER_NOT_AVAILABLE: Unable to query leaders from the given partitions.
* - RD_KAFKA_RESP_ERR__TIMED_OUT: Not all offsets could be fetched in time.
* - RD_KAFKA_RESP_ERR__UNKNOWN_PARTITION: All partitions are unknown.
* - RD_KAFKA_RESP_ERR_LEADER_NOT_AVAILABLE: Unable to query leaders from the given partitions.
*/
std::map<TopicPartition, Offset> offsetsForTime(const TopicPartitions& tps,
std::chrono::time_point<std::chrono::system_clock> timepoint,
Expand Down
6 changes: 6 additions & 0 deletions include/kafka/ProducerConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@ class ProducerConfig: public Properties
*/
static const constexpr char* BATCH_NUM_MESSAGES = "batch.num.messages";

/**
* Maximum size (in bytes) of all messages batched in one MessageSet (including protocol framing overhead).
* Default value: 1000000
*/
static const constexpr char* BATCH_SIZE = "batch.size";

/**
* Maximum Kafka protocol request message size.
* Note: Should be coordinated with the bokers's configuration. Otherwise, any larger message would be rejected!
Expand Down
Loading