♻️ Consolidate mpm.json persistence through ProjectRepository#254
Merged
♻️ Consolidate mpm.json persistence through ProjectRepository#254
Conversation
Route all mpm.json reads/writes exclusively through ProjectRepository instead of direct file I/O scattered across services.
Contributor
🚀 Preview of mpmThis preview file are availalble for 7 days. (until 2026-04-05)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mpm.jsonreads/writes exclusively throughProjectRepositoryinstead of direct file I/O scattered acrossPluginInfoServiceImpl,PluginLifecycleServiceImpl,PluginUpdateServiceImpl, andProjectServiceImplfindOrError()method toProjectRepositoryinterface to distinguish between "file not found" and "parse error" (prevents behavioral regression where corruptmpm.jsonwould appear as "not initialized")MpmProjectdomain model methods (addPlugin,removePlugin,getPluginSpec,toDto) instead of rawMpmConfigDTO manipulation in servicesTest plan
./gradlew checkpasses (all existing tests pass)mpm initcreatesmpm.jsoncorrectlympm add <plugin>works with latest/fixed/sync version specifiersmpm remove <plugin>correctly updatesmpm.jsonmpm.jsonreturns parse error (not "not initialized")Closes #236