Add --follower routing to --irace mode without explicit --irace#361
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates IRACE-related CLI behavior and documentation so that --follower can start the IRACE execution controller (follower mode) without requiring an explicit --irace, and clarifies the “tuning” terminology across configs/docs.
Changes:
- Route
--followerstartup to the IRACE orchestrator when available (so follower mode works without--irace). - Update IRACE documentation/config comments to describe “IRACE tuning mode” and document follower mode.
- Minor YAML formatting adjustments in the template
application.yml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
core/src/main/java/es/urjc/etsii/grafo/solver/RunOnStart.java |
Adds --follower argument routing to the IRACE orchestrator and refactors name normalization. |
docs/features/irace.md |
Documents follower mode usage and updates wording to “IRACE tuning mode”. |
core/src/main/resources/application.yml |
Updates IRACE-related comments to mention tuning mode and follower mode. |
template/src/main/resources/application.yml |
Updates IRACE-related comments to mention tuning mode and follower mode; minor formatting tweak. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+64
to
+66
| private static String normalizeName(String value) { | ||
| return value.replaceAll("[-_]", "").toLowerCase(); | ||
| } |
Comment on lines
+56
to
+61
| private String resolveOrchestratorName(String arg) { | ||
| var name = normalizeName(arg); | ||
| if ("follower".equals(name) && orchestrators.containsKey("irace")) { | ||
| return "irace"; | ||
| } | ||
| return name; |
| @@ -14,7 +14,7 @@ https://cran.r-project.org/web/packages/irace/vignettes/irace-package.pdf | |||
|
|
|||
| ## Activating IRACE mode | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.