Skip to content

fix: add time within for safe, finized#124

Merged
MarvelFisher merged 1 commit into
morph-l2:mainfrom
SpectreMercury:fix-statues-docs
Jan 22, 2026
Merged

fix: add time within for safe, finized#124
MarvelFisher merged 1 commit into
morph-l2:mainfrom
SpectreMercury:fix-statues-docs

Conversation

@SpectreMercury
Copy link
Copy Markdown
Contributor

@SpectreMercury SpectreMercury commented Jan 22, 2026

Summary by CodeRabbit

  • Documentation
    • Added timing estimates for Morph mainnet transaction status transitions: latest (2–4 seconds), safe (5–10 minutes), and finalized (15–20 minutes).

✏️ Tip: You can customize this high-level summary in your review settings.

@SpectreMercury SpectreMercury requested a review from a team as a code owner January 22, 2026 06:22
@SpectreMercury SpectreMercury requested review from tomatoishealthy and removed request for a team January 22, 2026 06:22
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 22, 2026

📝 Walkthrough

Walkthrough

This pull request adds a new subsection to the Morph mainnet transaction statuses documentation page, providing specific time-to-state transition estimates for three transaction states: latest (2–4 seconds), safe (5–10 minutes to 12 hours), and finalized (15–20 minutes to 12 hours).

Changes

Cohort / File(s) Summary
Documentation: Transaction Status Timing
docs/how-morph-works/general-protocol-design/3-transaction-statuses-on-morph-mainnet.md
Adds timing guidance for transaction state transitions, clarifying expected duration ranges for latest, safe, and finalized states

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • twcctop

Poem

🐰 With whiskers twitching at protocol pace,
I hop through timing, adding grace,
From latest quick to finalized slow,
The Morph transactions now will flow!
thump thump — Documentation hops along 📜

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title mentions adding time estimates for 'safe' and 'finized' (misspelled), which aligns with the actual changes of adding transaction status timing information to documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In
`@docs/how-morph-works/general-protocol-design/3-transaction-statuses-on-morph-mainnet.md`:
- Line 27: The phrase "Sequencer confirmed / unsafe (`latest`)" uses the
undefined term "unsafe"; update that line to remove "unsafe" so it reads
"Sequencer confirmed (`latest`):" to match the state definitions (Pending,
Latest, Safe, Finalized), ensuring terminology is consistent across the
document; alternatively, if you intend "unsafe" as a distinct state, add a
corresponding definition for "unsafe" to the state definitions table and clarify
its relation to `latest`.


### Typical time to reach each state

- **Sequencer confirmed / unsafe (`latest`):** Typically within 2–4 seconds, reflecting the L2 block production time.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Terminology inconsistency: "unsafe" is not defined in this document.

Line 27 refers to "unsafe" when describing the latest state, but "unsafe" is not defined in the state definitions table (lines 16-21). The table only defines: Pending, Latest, Safe, and Finalized.

Consider removing "unsafe" to maintain consistency with the document's terminology, or add a definition for "unsafe" in the state definitions table if it represents a distinct concept.

📝 Suggested fix
-- **Sequencer confirmed / unsafe (`latest`):** Typically within 2–4 seconds, reflecting the L2 block production time.
+- **Sequencer confirmed (`latest`):** Typically within 2–4 seconds, reflecting the L2 block production time.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- **Sequencer confirmed / unsafe (`latest`):** Typically within 2–4 seconds, reflecting the L2 block production time.
- **Sequencer confirmed (`latest`):** Typically within 2–4 seconds, reflecting the L2 block production time.
🤖 Prompt for AI Agents
In
`@docs/how-morph-works/general-protocol-design/3-transaction-statuses-on-morph-mainnet.md`
at line 27, The phrase "Sequencer confirmed / unsafe (`latest`)" uses the
undefined term "unsafe"; update that line to remove "unsafe" so it reads
"Sequencer confirmed (`latest`):" to match the state definitions (Pending,
Latest, Safe, Finalized), ensuring terminology is consistent across the
document; alternatively, if you intend "unsafe" as a distinct state, add a
corresponding definition for "unsafe" to the state definitions table and clarify
its relation to `latest`.

@MarvelFisher MarvelFisher merged commit d7b0f2f into morph-l2:main Jan 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants