Skip to content

Bump up geth version#959

Merged
chengwenxi merged 8 commits into
mainfrom
geth-sync
May 28, 2026
Merged

Bump up geth version#959
chengwenxi merged 8 commits into
mainfrom
geth-sync

Conversation

@SegueII
Copy link
Copy Markdown
Contributor

@SegueII SegueII commented May 26, 2026

Summary by CodeRabbit

  • Chores

    • Updated Ethereum-related dependencies across multiple modules to newer versions.
  • Bug Fixes

    • Fixed handling of large fee values in blob transactions to prevent value truncation during gas limit adjustments.

Review Change Stack

SegueII added 6 commits May 12, 2026 18:21
…a7 across multiple modules and remove references to v1.10.26. Adjust Makefile to reflect new target version.
…e handling in rollup service to use new big.Int methods for improved precision.
…fb across multiple modules and adjust Makefile to reflect the new target version.
…88 across multiple modules and adjust Makefile to reflect the new target version.
@SegueII SegueII requested a review from a team as a code owner May 26, 2026 09:48
@SegueII SegueII requested review from panos-xyz and removed request for a team May 26, 2026 09:48
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aad57be8-2363-4ee2-8dcc-4bd42913302e

📥 Commits

Reviewing files that changed from the base of the PR and between cafa07d and c0e6806.

⛔ Files ignored due to path filters (9)
  • bindings/go.sum is excluded by !**/*.sum
  • contracts/go.sum is excluded by !**/*.sum
  • go.work.sum is excluded by !**/*.sum
  • node/go.sum is excluded by !**/*.sum
  • ops/l2-genesis/go.sum is excluded by !**/*.sum
  • ops/tools/go.sum is excluded by !**/*.sum
  • oracle/go.sum is excluded by !**/*.sum
  • token-price-oracle/go.sum is excluded by !**/*.sum
  • tx-submitter/go.sum is excluded by !**/*.sum
📒 Files selected for processing (11)
  • Makefile
  • bindings/go.mod
  • contracts/go.mod
  • go-ethereum
  • node/go.mod
  • ops/l2-genesis/go.mod
  • ops/tools/go.mod
  • oracle/go.mod
  • token-price-oracle/go.mod
  • tx-submitter/go.mod
  • tx-submitter/services/rollup.go

📝 Walkthrough

Walkthrough

The PR upgrades the go-ethereum dependency from morph-v2.2.2 to morph-v2.2.3, updating the Makefile build pins, submodule commit, and all go.mod dependency declarations. Transaction fee handling in tx-submitter is fixed to avoid int64 truncation, preserving full precision for large fee values.

Changes

Ethereum Dependency Upgrade and Fee Precision Fixes

Layer / File(s) Summary
Ethereum submodule and build version pins
Makefile, .gitmodules (go-ethereum)
ETHEREUM_SUBMODULE_COMMIT_OR_TAG and ETHEREUM_TARGET_VERSION are bumped from morph-v2.2.2 to morph-v2.2.3; the go-ethereum submodule reference is updated to the corresponding commit hash.
Go module dependency synchronization across packages
bindings/go.mod, contracts/go.mod, node/go.mod, ops/l2-genesis/go.mod, ops/tools/go.mod, oracle/go.mod, token-price-oracle/go.mod, tx-submitter/go.mod
All go.mod files are synchronized to the new github.com/morph-l2/go-ethereum version. The indirect dependency github.com/ethereum/go-ethereum v1.10.26 is removed from contracts, node, ops/l2-genesis, ops/tools, oracle, and token-price-oracle modules.
Transaction fee precision preservation in blob and dynamic fee handling
tx-submitter/services/rollup.go
createBlobTx now uses uint256.MustFromBig() to preserve full precision when setting GasTipCap and GasFeeCap from big.Int values. UpdateGasLimit replaces int64-based truncation with big.Int.Set() for legacy and dynamic fee types, and uint256.MustFromBig() for blob transactions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • morph-l2/morph#918: Both PRs update the same Ethereum dependency version pins in Makefile and go.mod files.
  • morph-l2/morph#914: Both PRs modify ETHEREUM_SUBMODULE_COMMIT_OR_TAG and ETHEREUM_TARGET_VERSION pinning and corresponding go.mod versions.
  • morph-l2/morph#756: Both PRs upgrade the github.com/morph-l2/go-ethereum dependency across build and go.mod files.

Suggested reviewers

  • panos-xyz
  • FletcherMan

🐰 A morph takes shape with gems so bright,
Precision preserved through the night,
No truncation here, just big.Int care,
Ethereum's gifts we proudly bear!
Version bumped, fees flowing true,
Another upgrade, solid through and through. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Bump up geth version' is directly related to the main change in the pull request—updating the go-ethereum (geth) dependency version across multiple files from morph-v2.2.2 to morph-v2.2.3, along with updating the submodule commit hash.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch geth-sync

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SegueII SegueII changed the title Update geth version Bump up geth version May 28, 2026
@chengwenxi chengwenxi merged commit 88792ef into main May 28, 2026
15 checks passed
@chengwenxi chengwenxi deleted the geth-sync branch May 28, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants