Skip to content

fix(upstream:PLA-688): stop non-retryable and write-path retries#27

Merged
0x666c6f merged 1 commit intomorpho-mainfrom
feature/pla-688-erpc-retry-correctness-hardening-non-retryable-fallthrough
Mar 4, 2026
Merged

fix(upstream:PLA-688): stop non-retryable and write-path retries#27
0x666c6f merged 1 commit intomorpho-mainfrom
feature/pla-688-erpc-retry-correctness-hardening-non-retryable-fallthrough

Conversation

@0x666c6f
Copy link
Copy Markdown
Collaborator

@0x666c6f 0x666c6f commented Mar 3, 2026

Summary

  • fix retry policy fallthrough for network-scope non-retryable errors
  • block retry attempts for non-retryable write methods even on error-only (result=nil) paths
  • add regression tests for both cases in upstream/failsafe_test.go

Changes

  • in createRetryPolicy, return false when IsRetryableTowardNetwork(err) is false
  • centralize request extraction from result/error/context via extractRetryRequest
  • use extracted request for write-method retry guard and missing-data retry-empty check
  • add tests:
    • NetworkScope_NonRetryableTowardNetwork_NoRetry
    • WriteMethodInContext_ErrorOnlyPath_NoRetry

Linear

@0x666c6f 0x666c6f self-assigned this Mar 3, 2026
@0x666c6f 0x666c6f merged commit 2127fa1 into morpho-main Mar 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant