Skip to content

perf(erpc:PLA-692): partial multicall fallback and terminal handling#35

Merged
0x666c6f merged 2 commits intomorpho-mainfrom
feature/pla-692-erpc-optimize-eth_call-fallback-partial-retry-avoid-double
Mar 4, 2026
Merged

perf(erpc:PLA-692): partial multicall fallback and terminal handling#35
0x666c6f merged 2 commits intomorpho-mainfrom
feature/pla-692-erpc-optimize-eth_call-fallback-partial-retry-avoid-double

Conversation

@0x666c6f
Copy link
Copy Markdown
Collaborator

@0x666c6f 0x666c6f commented Mar 3, 2026

Summary

  • Reduce multicall fallback amplification in eth_call batch aggregation.
  • Retry only failed subcalls while preserving successful multicall subresults.

Changes

  • retry failed decoded multicall3 subcalls individually (partial fallback)
  • keep successful decoded subcalls as direct multicall results (no re-forward)
  • treat terminal multicall response corruption paths as terminal errors (no full fallback re-forward)
  • classify multicall RPC errors into recoverable (fallback) vs terminal (no fallback)
  • add fallback-reason matrix metric:
    • erpc_multicall3_fallback_reason_matrix_total{reason,mode}
    • mode: full|partial|terminal
  • wire erpc_multicall3_fallback_requests_total{outcome} in fallback worker path
  • update aggregation/fallback regression tests for new behavior

Linear

@0x666c6f 0x666c6f self-assigned this Mar 3, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6501b5fa26

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread erpc/http_batch_eth_call.go Outdated
@0x666c6f 0x666c6f changed the base branch from feature/pla-691-erpc-burst-coalescing-deterministic-negative-cache-for-read to morpho-main March 4, 2026 16:49
@0x666c6f 0x666c6f merged commit 2eaa55d into morpho-main Mar 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant