feat(erpc:PLA-708): land block-identity + fallback-regression tip on morpho-main#45
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbdd8d621c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if common.HasErrorCode(err, common.ErrCodeEndpointRequestCanceled) { | ||
| observed = true |
There was a problem hiding this comment.
requestObservedHedgeCancellation checks req.ErrorsByUpstream for ErrCodeEndpointRequestCanceled, but canceled hedge attempts are not persisted in that map (they are dropped during upstream completion handling), so this condition is never observed in practice. As a result, when a hedge is launched but the non-hedged attempt wins, hedgeObserved stays false and MetricNetworkHedgeLostTotal is not incremented, which skews hedge effectiveness telemetry.
Useful? React with 👍 / 👎.
…add-sanity-checks-on-block-to-validate-them-or-change # Conflicts: # common/defaults_test.go # common/network.go # erpc/networks.go # erpc/networks_attempt_metrics_test.go # erpc/networks_multiplexer_test.go # monitoring/prometheus/alert.rules # upstream/failsafe.go # upstream/registry.go
1 participant
Mainline catch-up PR.
Context:
feature/pla-603.../feature/pla-336...) instead ofmorpho-main.morpho-main.Validation run locally:
make test-fallback-configgo test ./architecture/evm -run "TestValidateBlock|TestUpstreamPostForward_IdentityValidationRunsWithNilDirectives|TestEnforceNonNullTaggedBlocks" -count=1This keeps the intended queue content on mainline without rewriting history.