Skip to content

remove yarn#451

Merged
QGarchery merged 7 commits into
mainfrom
remove-yarn
Apr 23, 2026
Merged

remove yarn#451
QGarchery merged 7 commits into
mainfrom
remove-yarn

Conversation

@MathisGD
Copy link
Copy Markdown
Contributor

No description provided.

@MathisGD MathisGD self-assigned this Apr 14, 2026
@MathisGD MathisGD requested review from QGarchery and adhusson April 14, 2026 07:50
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f97bbf49a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .gitignore
@MathisGD MathisGD requested a review from peyha April 19, 2026 22:19
Copy link
Copy Markdown

@peyha peyha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yarn tests are essentially gas tests, not really worth keeping

prd-carapulse Bot added a commit to morpho-org/metamorpho-v1.1 that referenced this pull request Apr 21, 2026
Remove all hardhat/yarn/husky scaffolding; move test/forge/* -> test/*.

Inspired by morpho-org/metamorpho#451.
Resolves conflicts with main by keeping the deletions of hardhat.yml
and npm-release.yml workflows (which this PR removes) while preserving
the pinned GitHub Actions SHAs introduced on main for the remaining
workflows (certora.yml, formatting.yml, foundry.yml).
@prd-carapulse
Copy link
Copy Markdown
Contributor

prd-carapulse Bot commented Apr 21, 2026

Resolved the merge conflict with main (conflict introduced by the action-SHA pinning PR #452).

New merge commit: 67d7690, parents = 6aba099 (previous remove-yarn tip) and adc6c3b (current main tip).

Conflict resolution:

  • .github/workflows/hardhat.yml and .github/workflows/npm-release.yml: kept deletion (this PR's intent)
  • .github/workflows/certora.yml, formatting.yml, foundry.yml: auto-merged — kept the forge-based steps from this branch and the pinned action SHAs from main

mergeable is now MERGEABLE (only blocked on a fresh review since the branch moved).

Comment thread .github/workflows/foundry.yml Outdated
Comment thread .github/actions/install/action.yml Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1840b574b8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/foundry.yml
Comment thread .github/workflows/foundry.yml
@QGarchery QGarchery merged commit 34f411a into main Apr 23, 2026
18 checks passed
@QGarchery QGarchery deleted the remove-yarn branch April 23, 2026 07:11
Copy link
Copy Markdown
Collaborator

@adhusson adhusson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants