trading fee#106
Merged
Merged
Conversation
Closed
peyha
reviewed
Sep 29, 2025
Closed
adhusson
reviewed
Sep 29, 2025
QGarchery
reviewed
Oct 1, 2025
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
Contributor
|
If we end up using two arguments |
peyha
reviewed
Oct 2, 2025
peyha
reviewed
Oct 3, 2025
peyha
left a comment
peyha
left a comment
Contributor
There was a problem hiding this comment.
confirming that I have the same formula for sellerAssets,buyerAssets and obligationUnits
Closed
feat: trading fee 2
adhusson
approved these changes
Oct 8, 2025
Contributor
|
The "primitive" in the PR message should be
|
Contributor
|
The justification of the current formula is that we have
cf this and that we use |
peyha
approved these changes
Oct 8, 2025
| } | ||
|
|
||
| require(_isHealthy(offer.obligation, seller), "Seller is unhealthy"); | ||
| } |
Contributor
There was a problem hiding this comment.
we could
Suggested change
| return (buyerAssets, sellerAssets, obligationUnits) | |
| } |
(but we can also raise an issue and do it later)
Collaborator
Author
There was a problem hiding this comment.
yes, will open an other PR!
QGarchery
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"primitive":
the computations should be such that