[continuous fee] per borrower, remaining#470
Conversation
Signed-off-by: Adrien Husson <adhusson@gmail.com>
adhusson
changed the title
…-borrower-continuous-fee-remaining
…-borrower-continuous-fee-remaining
adhusson
changed the base branch from
feat/per-borrower-continuous-fee-average
to
main
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06bc9e2c80
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…or/no-duplicate-rgs
…or/no-duplicate-rgs
…or/no-duplicate-rgs
no duplicate args in external interface
| Position storage _position = position[id][user]; | ||
| uint128 _userLossIndex = _position.lossIndex; | ||
| uint128 lossIndex = obligationState[id].lossIndex; | ||
| if (_userLossIndex == lossIndex) return _position.credit; |
There was a problem hiding this comment.
| if (_userLossIndex == lossIndex) return _position.credit; |
would work similarly except if _userlossIndex=type(uint128.max) so it would feel cleaner to not do this check or to check ``_userlossIndex==type(uint128.max)` instead
There was a problem hiding this comment.
We had a problem in the spec when the implementation of creditAfterSlashing differs from slash: if the loss index and the user loss index are both at max, then slash reverts but creditAfterSlashing doesn't
…tinuous-fee-remaining
…-remaining' into feat/per-borrower-continuous-fee-remaining
…tinuous-fee-remaining
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b05808ee7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
closing in favor of #547 |
4 participants
continuous fee implementation
specs done
rest of verif wish list moved to #109
good summary of the tradeoffs here