[Certora] improve onlyXXXCanChange specs#490
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e23e3613b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
QGarchery
changed the title
MathisGD
commented
Mar 10, 2026
MathisGD
commented
Mar 10, 2026
MathisGD
commented
Mar 10, 2026
MathisGD
commented
Mar 10, 2026
MathisGD
commented
Mar 10, 2026
QGarchery
changed the title
MathisGD
commented
Mar 10, 2026
MathisGD
commented
Mar 10, 2026
QGarchery
requested review from
bhargavbh,
jhoenicke and
lilCertora
and removed request for
QGarchery
lilCertora
reviewed
Mar 11, 2026
lilCertora
approved these changes
Mar 11, 2026
Collaborator
There was a problem hiding this comment.
LGTM , it is very clean this way
2 ideas :
- having a rule like
takeCannotChangeBothSharesAndDebtmay be a nice addition ? prover link - this spec could be extended to
collateralOfin the future now as it has been renamed
Co-authored-by: lilCertora <lilian@certora.com> Signed-off-by: Quentin Garchery <garchery.quentin@gmail.com>
jhoenicke
approved these changes
Mar 11, 2026
Co-authored-by: Jochen Hoenicke <hoenicke@gmail.com> Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
lilCertora
approved these changes
Mar 11, 2026
QGarchery
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.