[Certora] Check that non-zero credit is not accessed before update even in take#608
Merged
Conversation
jhoenicke
commented
Mar 30, 2026
| emit EventsLib.UpdatePosition(id, user, creditDecrease, pendingFeeDecrease, accruedFee); | ||
| } | ||
|
|
||
| function hasCredit(bytes32 id, address user) internal view returns (bool) { |
Collaborator
Author
There was a problem hiding this comment.
I also tried using Position storage argument here. Unfortunately storage arguments are not supported by the Certora Prover.
MathisGD
reviewed
Mar 30, 2026
| emit EventsLib.UpdatePosition(id, user, creditDecrease, pendingFeeDecrease, accruedFee); | ||
| } | ||
|
|
||
| function hasCredit(bytes32 id, address user) internal view returns (bool) { |
Collaborator
There was a problem hiding this comment.
how painful would it be to do a munging for this rule?
Collaborator
Author
There was a problem hiding this comment.
We can't do it with wrapper contracts, but would need to setup munging to copy the contract, apply a diff, and then run verification on the copy. We don't have any setup for munging yet, and it adds the risk that we verify a different contract.
MathisGD
approved these changes
Mar 30, 2026
adhusson
approved these changes
Mar 30, 2026
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the updateBeforeCredit spec to include take again.