Skip to content

arbitrary callback targets#688

Merged
MathisGD merged 16 commits into
mainfrom
arbitrary-callback-targets
Apr 20, 2026
Merged

arbitrary callback targets#688
MathisGD merged 16 commits into
mainfrom
arbitrary-callback-targets

Conversation

@MathisGD
Copy link
Copy Markdown
Contributor

@MathisGD MathisGD commented Apr 14, 2026

@MathisGD MathisGD self-assigned this Apr 14, 2026
chatgpt-codex-connector[bot]

This comment was marked as resolved.

chatgpt-codex-connector[bot]

This comment was marked as resolved.

Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
chatgpt-codex-connector[bot]

This comment was marked as resolved.

chatgpt-codex-connector[bot]

This comment was marked as resolved.

chatgpt-codex-connector[bot]

This comment was marked as resolved.

Comment thread src/Midnight.sol Outdated
Comment thread src/Midnight.sol Outdated
Comment thread src/Midnight.sol Outdated
Comment thread test/FlashloanTest.sol
chatgpt-codex-connector[bot]

This comment was marked as outdated.

chatgpt-codex-connector[bot]

This comment was marked as resolved.

Comment thread src/libraries/EventsLib.sol Outdated
chatgpt-codex-connector[bot]

This comment was marked as outdated.

Comment thread src/Midnight.sol Outdated
Copy link
Copy Markdown
Contributor

@peyha peyha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending event discussion

chatgpt-codex-connector[bot]

This comment was marked as resolved.

Comment thread src/Midnight.sol
Comment thread src/Midnight.sol Outdated
Comment thread src/Midnight.sol Outdated
@MathisGD MathisGD requested a review from QGarchery April 17, 2026 19:00
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 563695b62a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Midnight.sol
@MathisGD MathisGD merged commit 730f908 into main Apr 20, 2026
28 of 29 checks passed
@MathisGD MathisGD deleted the arbitrary-callback-targets branch April 20, 2026 12:43
peyha pushed a commit that referenced this pull request Apr 28, 2026
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
@adhusson
Copy link
Copy Markdown
Contributor

adhusson commented May 1, 2026

LGTM, added tests for sender != callback #765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants