Skip to content
This repository was archived by the owner on Dec 18, 2025. It is now read-only.

Fix/oracle#2

Merged
MerlinEgalite merged 11 commits into
mainfrom
fix/oracle
Jul 10, 2021
Merged

Fix/oracle#2
MerlinEgalite merged 11 commits into
mainfrom
fix/oracle

Conversation

@MathisGD
Copy link
Copy Markdown
Collaborator

@MathisGD MathisGD commented Jul 9, 2021

Fixes #1

Comment thread contracts/oracle/ChainlinkOracle.sol
@MathisGD
Copy link
Copy Markdown
Collaborator Author

MathisGD commented Jul 9, 2021

In c5679be, I don't see the "adaptation to oracle"

@MathisGD
Copy link
Copy Markdown
Collaborator Author

MathisGD commented Jul 9, 2021

8b375c3 can quickly and easily be squashed with 548fe0e, for better readability (liiiiiittle detail)

@MerlinEgalite
Copy link
Copy Markdown
Contributor

In c5679be, I don't see the "adaptation to oracle"

this is for testing. Since ETH price is the real one you need more DAI as collateral to borrow ETH

@MerlinEgalite
Copy link
Copy Markdown
Contributor

8b375c3 can quickly and easily be squashed with 548fe0e, for better readability (liiiiiittle detail)

have been squashed ✅

@MerlinEgalite MerlinEgalite merged commit e3a430f into main Jul 10, 2021
@MathisGD
Copy link
Copy Markdown
Collaborator Author

Nice job

@MerlinEgalite MerlinEgalite deleted the fix/oracle branch August 1, 2021 14:02
MerlinEgalite added a commit that referenced this pull request Jun 13, 2022
MerlinEgalite added a commit that referenced this pull request Aug 12, 2022
MathisGD added a commit that referenced this pull request Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Fix oracle everywhere (to get token prices)

2 participants