This repository was archived by the owner on Apr 18, 2026. It is now read-only.
[Tests] Fix bounds in the revert conditions#113
Merged
Conversation
QGarchery
requested review from
MathisGD,
MerlinEgalite,
Rubilmax,
Tristan22400,
makcandrov and
pakim249CAL
Changes to gas cost
🧾 Summary (20% most significant diffs)
Full diff report 👇
|
QGarchery
changed the title
Rubilmax
approved these changes
Jun 14, 2023
Contributor
Rubilmax
left a comment
Rubilmax
left a comment
There was a problem hiding this comment.
Aaaah I went too fast again...
makcandrov
approved these changes
Jun 14, 2023
Tristan22400
approved these changes
Jun 14, 2023
MerlinEgalite
approved these changes
Jun 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bounds are subtracting one instead of adding one, see failing tests in the first commit