Improve delegate call #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
requested changes
Jul 27, 2022
Contributor
MerlinEgalite
left a comment
MerlinEgalite
left a comment
There was a problem hiding this comment.
Small code improvements
delete unused lib
MerlinEgalite
force-pushed
the
feat/mep-delegate-call
branch
from
65dda1f to
c3d0388
Compare
Changes to gas costs🧾 Summary
Full diff report 👇
|
MerlinEgalite
approved these changes
Jul 27, 2022
Co-authored-by: AtomicAzzaz <75758585+AtomicAzzaz@users.noreply.github.com> Signed-off-by: Merlin <44097430+MerlinEgalite@users.noreply.github.com>
Optimize delegate call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of delegateCall library written in Yul
We focus on the "max" columns of gas reports: when the delegateCall doesn't revert
OZ inspired delegateCall :
Yul optimized delegateCall :