Skip to content

✨ Add weighted avg #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MerlinEgalite merged 6 commits into from
Aug 2, 2022
Merged

✨ Add weighted avg #32

MerlinEgalite merged 6 commits into from
Aug 2, 2022

Conversation

@Rubilmax
Copy link
Contributor

@Rubilmax Rubilmax commented Aug 1, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 1, 2022 •
edited
Loading

Changes to gas costs

🧾 Summary

Contract Method Avg (+/-) %
PercentageMathFunctionsRef percentDiv
percentMul		 +22 ❌
+11 ❌		 -0.11%
-0.05%
PercentageMathFunctions percentMul
percentDiv		 +22 ❌
+22 ❌		 -0.11%
-0.11%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
PercentageMathFunctionsRef 108,153 (+48,842) percentDiv
percentMul		 432 (+22)
424 (+11)		 -0.11%
-0.05%		 432 (+22)
424 (+11)		 -0.11%
-0.05%		 432 (+22)
424 (+11)		 -0.11%
-0.05%		 432 (+22)
424 (+11)		 -0.11%
-0.05%		 1 (0)
1 (0)
PercentageMathFunctions 110,159 (+52,248) percentMul
percentDiv		 431 (+22)
424 (+22)		 -0.11%
-0.11%		 431 (+22)
424 (+22)		 -0.11%
-0.11%		 431 (+22)
424 (+22)		 -0.11%
-0.11%		 431 (+22)
424 (+22)		 -0.11%
-0.11%		 1 (0)
1 (0)

MerlinEgalite
MerlinEgalite requested changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes to add

@Rubilmax Rubilmax requested a review from MerlinEgalite August 1, 2022 13:27
QGarchery
QGarchery reviewed Aug 1, 2022
View reviewed changes
@Rubilmax Rubilmax requested a review from QGarchery August 1, 2022 13:31
MathisGD
MathisGD requested changes Aug 1, 2022
View reviewed changes
@Rubilmax Rubilmax requested a review from MathisGD August 1, 2022 14:03
@Rubilmax Rubilmax force-pushed the feat/add-percent-avg branch from 04b5a10 to 4d4ac06 Compare August 2, 2022 12:00
@Rubilmax Rubilmax force-pushed the feat/add-percent-avg branch from 4d4ac06 to ca42574 Compare August 2, 2022 12:01
@Rubilmax Rubilmax changed the title ✨ Add percent avg ✨ Add weighted avg Aug 2, 2022
MerlinEgalite
MerlinEgalite approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment but LGTM

@QGarchery
Copy link
Contributor

QGarchery commented Aug 2, 2022

Just a comment but LGTM

Where is this comment @MerlinEgalite ? I don't see it

@MerlinEgalite
Copy link
Contributor

MerlinEgalite commented Aug 2, 2022

Just a comment but LGTM

Where is this comment @MerlinEgalite ? I don't see it

here #32 (comment)

@QGarchery
Copy link
Contributor

QGarchery commented Aug 2, 2022

Just a comment but LGTM

Where is this comment @MerlinEgalite ? I don't see it

here #32 (comment)

This link points to my comment hehe

@MerlinEgalite MerlinEgalite merged commit cb43513 into main Aug 2, 2022
@Rubilmax Rubilmax deleted the feat/add-percent-avg branch December 13, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QGarchery QGarchery QGarchery approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@MathisGD MathisGD Awaiting requested review from MathisGD

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Rubilmax @QGarchery @MerlinEgalite @MathisGD