Fix too strong conditions in tests #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
approved these changes
Aug 3, 2022
Rubilmax
approved these changes
Aug 3, 2022
| assertEq(Math.divUp(x, y), x / y); | ||
| } | ||
|
|
||
| function testDivUpWhenNumLargerAndNotDivisible(uint256 x, uint256 y) public { |
Contributor
There was a problem hiding this comment.
I know test names are large but it makes reading a test report & the code easier by giving a clear context
I don't think it's the case for testDivUpNotDivisible which does not indicate whether it's the numerator or the denominator which is not divisible
I would recommend testDivUpNumNotDivisible and testDivUpNumDivisible, if making test names shorter is meaningful
Contributor
Author
There was a problem hiding this comment.
which does not indicate whether it's the numerator or the denominator which is not divisible
this is implicit (why would you care about the inverse)
But I can re-add that if you want!
QGarchery
approved these changes
Aug 3, 2022
MathisGD
force-pushed
the
test/fix-conditions
branch
from
56c9dd1 to
406c728
Compare
MathisGD
force-pushed
the
test/fix-conditions
branch
from
406c728 to
f13d329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.