refactor(morpho-sdk): drop useSimplePermit from vaultV1 migrateToV2#601
Merged
Conversation
V1 vault shares always implement EIP-2612, so the Permit2 fallback was unreachable on this path. `migrateToV2().getRequirements()` no longer accepts the flag and always uses simple permit. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
0xbulma
reviewed
May 4, 2026
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
alexbensimon
approved these changes
May 4, 2026
0xbulma
changed the title
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MorphoVaultV1.migrateToV2().getRequirements()no longer acceptsuseSimplePermit. V1 vault shares always implement EIP-2612, so the Permit2 fallback was unreachable on this code path.useSimplePermit: truein the underlyinggetRequirementscall.getRequirements()with no args.Scope: only the vaultV1 → V2 migration entity.
vaultV1.deposit,vaultV2.deposit, andmarketV1paths still exposeuseSimplePermitbecause they operate on underlying assets (USDC, WETH, …) that may not implement EIP-2612.