Fix duplicate install layout in MSI (WiX Files + project ref)#241
Merged
Fix duplicate install layout in MSI (WiX Files + project ref)#241
Conversation
ProjectReference adds an unnamed bind path; bare ** harvested TargetDir and duplicated publish layout (wixtoolset/issues#9084). Fixes #240. Made-with: Cursor
Remove unused binaries input and certificate artifact upload. Rename steps for clarity. Keep dotnet 9.x to match the app target. Made-with: Cursor
mortenn
added a commit
that referenced
this pull request
Mar 23, 2026
Cherry-pick #241: WiX duplicate install layout + build-installer action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #240: dependent (and portable) MSIs installed the same payload twice as
runtimes\andpublish\runtimes\because WiXFiles Include="**"with a ProjectReference resolves against the reference's unnamed bind path (TargetDir), notComponentGroup Source, so the whole build output—including thepublish\subfolder—was harvested. See wixtoolset/issues#9084.Changes
$(var.BrowserPicker.App.TargetDir)\publish\**and the portablewin-x64\publish\**variant) indist/Dependent/Product.wxsanddist/Portable/Product.wxs.build-signed→build-installer, drop unusedbinariesinput and the release job's cert artifact upload (signing was already removed from steps). Keep dotnet 9.x in the composite action to match currentnet9.0-windowsonmain.Verification
Administrative extract of a built MSI should show no
publish\directory under the install root; layout should match the published app folder (as in the Dependent zip artifact).